Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Block Inserter: Limit Jetpack block collection to the WordPress app #25155

Merged
merged 8 commits into from
Jul 26, 2022

Conversation

SiobhyB
Copy link

@SiobhyB SiobhyB commented Jul 21, 2022

Addresses the discussion at #25092 (comment).

Related PRs

Changes proposed in this Pull Request:

Jetpack product discussion

Discussion related to this enhancement happened at #25092 (comment).

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

Installable builds for both the iOS and Android apps can be found in the following PRs:

To help test, go through the following steps for each PR and app:

Jetpack app:
  • Download and open the Jetpack app.
  • Navigate to the post editor and tap the + icon.
  • Scroll to the bottom of the block list and confirm that there isn't a highlighted Jetpack section.
WordPress app:
  • Download and open the WordPress app.
  • Navigate to the post editor and tap the + icon.
  • Scroll to the bottom of the block list and confirm that there is a highlighted Jetpack section.
Screenshots
Jetpack WordPress

@SiobhyB SiobhyB added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label Jul 21, 2022
@SiobhyB SiobhyB self-assigned this Jul 21, 2022
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Jul 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: August 2, 2022.
  • Scheduled code freeze: July 25, 2022.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello SiobhyB! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D84650-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@SiobhyB SiobhyB changed the title [WIP] [RNMobile] Block Inserter: Limit Jetpack block collection to the WordPress app Jul 21, 2022
dcalhoun
dcalhoun previously approved these changes Jul 25, 2022
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀 I verified the Jetpack block collection was displayed in the WordPress app and hidden in the Jetpack app on an iPhone SE (iOS 15.6) and a Samsung Galaxy S20 (Android 12).

@SiobhyB SiobhyB added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jul 26, 2022
@SiobhyB
Copy link
Author

SiobhyB commented Jul 26, 2022

Thank you, David! 🙌

For the Jetpack crew: I don't have commit access to WP.com, so would be grateful if you could handle that portion of the merge for me. Thanks in advance 🙇‍♀️

@jeherve jeherve added this to the jetpack/11.2 milestone Jul 26, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 26, 2022
@jeherve jeherve enabled auto-merge (squash) July 26, 2022 08:16
@jeherve jeherve merged commit cbd9613 into trunk Jul 26, 2022
@jeherve jeherve deleted the rnmobile/limit-block-collection-to-wordpress-app branch July 26, 2022 08:31
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 26, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D84650-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

@jeherve
Copy link
Member

jeherve commented Jul 26, 2022

r249598-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [JS Package] Publicize Components [JS Package] Shared Extension Utils [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants