-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Block Inserter: Limit Jetpack block collection to the WordPress app #25155
[RNMobile] Block Inserter: Limit Jetpack block collection to the WordPress app #25155
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Caution: This PR has changes that must be merged to WordPress.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀 I verified the Jetpack block collection was displayed in the WordPress app and hidden in the Jetpack app on an iPhone SE (iOS 15.6) and a Samsung Galaxy S20 (Android 12).
Thank you, David! 🙌 For the Jetpack crew: I don't have commit access to WP.com, so would be grateful if you could handle that portion of the merge for me. Thanks in advance 🙇♀️ |
…-collection-to-wordpress-app
Great news! One last step: head over to your WordPress.com diff, D84650-code, and deploy it. Thank you! |
r249598-wpcom |
Addresses the discussion at #25092 (comment).
Related PRs
Gutenberg Mobile
: Enable the native editor to receive a host app's namespace wordpress-mobile/gutenberg-mobile#5040Changes proposed in this Pull Request:
getHostAppNamespace()
, has been added to theprojects/js-packages/shared-extension-utils
directory. This new function makes it possible to retrieve a host app's namespace from within the Jetpack codebase. This will be useful in cases where it's necessary to check whether the Jetpack or WordPress app is in use.block-category.js
file. i.e. the Jetpack collection has a!isWpcom
conditional wrapped around it.Jetpack product discussion
Discussion related to this enhancement happened at #25092 (comment).
Does this pull request change what data or activity we track or use?
No, it does not.
Testing instructions:
Installable builds for both the iOS and Android apps can be found in the following PRs:
iOS
: [Gutenberg Mobile] Enable the native editor to receive a host app's namespace wordpress-mobile/WordPress-iOS#19084Android
: [Gutenberg Mobile] Enable the native editor to receive a host app's namespace wordpress-mobile/WordPress-Android#16935To help test, go through the following steps for each PR and app:
Jetpack app:
WordPress app:
Screenshots