Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost: Add jetpack compatibility tests #22124

Merged
merged 9 commits into from
Dec 24, 2021
Merged

Boost: Add jetpack compatibility tests #22124

merged 9 commits into from
Dec 24, 2021

Conversation

karthikax
Copy link
Contributor

Changes proposed in this Pull Request:

  • Add tests for Jetpack compatibility
  • List according to Boost: Create non core E2E tests #22019:
    • Core Test Id 9
    • Core Test Id 10
  • To retrieve the core Jetpack module status, this PR also adds a function isModuleActive to e2e-commons - prerequisites.js

Jetpack product discussion

Slack : archives/C0232B8CUHG/p1639639809027900

Does this pull request change what data or activity we track or use?

No

Testing instructions:

@karthikax karthikax added [Status] Needs Team Review E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. labels Dec 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Boost plugin:

  • Next scheduled release: January 31, 2022.
  • Scheduled code freeze: January 24, 2022.

@haqadn
Copy link
Contributor

haqadn commented Dec 23, 2021

The changes look good. But seems like jetpack CLI is missing and tests are failing as a result?

@karthikax
Copy link
Contributor Author

Oh, Yes. Not sure how this was passing with my local setup. Thanks, @eAdnan007.
Fixing this now!

haqadn
haqadn previously approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@karthikax karthikax added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Dec 24, 2021
@karthikax
Copy link
Contributor Author

karthikax commented Dec 24, 2021 •
edited
Loading

Thanks, @eAdnan007. I am requesting crew team review as well since PR includes changes in tools/e2e-commons.

brbrr
brbrr reviewed Dec 24, 2021
View reviewed changes
projects/plugins/boost/tests/e2e/specs/jetpack-compatibility.test.js Outdated
deactivateModules as deactivateBoostModules,
} from '../lib/env/prerequisites.js';

let jetpackBoostPage;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this variable to be global?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started with this to manipulate the same page with multiple tests. It is no more valid. Thanks for pointing out @brbrr

brbrr
brbrr previously approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I left a small nit-pick, but feel free to ignore it :)

@karthikax karthikax dismissed stale reviews from brbrr and haqadn via 0d542d0 December 24, 2021 12:55
@karthikax karthikax enabled auto-merge (squash) December 24, 2021 13:12
@karthikax karthikax merged commit 4c1a476 into master Dec 24, 2021
@karthikax karthikax deleted the add/jetpack-compatibility-test branch December 24, 2021 13:17
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 24, 2021
@github-actions github-actions bot added this to the boost/1.3.2 milestone Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

@haqadn haqadn haqadn left review comments

@thingalon thingalon Awaiting requested review from thingalon

@pyronaur pyronaur Awaiting requested review from pyronaur

@adimoldovan adimoldovan Awaiting requested review from adimoldovan

Assignees
No one assigned
Labels
E2E Tests [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikax @haqadn @brbrr