Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Update get-contributor-list script to allow -beta #22108

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

sdixon194
Copy link
Contributor

Changes proposed in this Pull Request:

When releasing a beta, the script currently won't let you check a version number in CHANGELOG.md such as 10.4-beta. This update will allow that match.

Jetpack product discussion

N/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

Easiest way is to go to Jetpack's CHANGELOG.md file and append -beta to the 10.4 release section, so it reads 10.4-beta.

Then try running tools/get-contributor-list.sh plugins/jetpack 10.4. Things should work fine. Without the extra regex, the script will fail.

@sdixon194 sdixon194 added the [Tools] Development CLI The tools/cli to assist during JP development. label Dec 15, 2021
@sdixon194 sdixon194 requested a review from anomiex December 15, 2021 18:13
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 15, 2021
@sdixon194 sdixon194 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 15, 2021
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will work.

@sdixon194 sdixon194 enabled auto-merge (squash) December 15, 2021 18:28
@sdixon194 sdixon194 merged commit a2aef5e into master Dec 15, 2021
@sdixon194 sdixon194 deleted the update/get-contributor-list-beta branch December 15, 2021 18:29
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tools] Development CLI The tools/cli to assist during JP development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants