-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support site_intent for /me/sites
endpoint
#21880
Support site_intent for /me/sites
endpoint
#21880
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Summary: As we need to show different support articles according to the site intent, add `site_intent` into options list so that we can query from the `/me/sites` endpoint Related to Automattic/wp-calypso#58486 Test Plan: 1. Go to https://[private link] 2. Select WP.COM API > v1.2 3. Use `/me/sites?fields=options&options=site_intent` 4. Check the response of sites contains `site_intent` Also, you can follow the testing instructions from Automattic/wp-calypso#58486 Reviewers: #ganon_team, philipmjackson Reviewed By: #ganon_team, philipmjackson Subscribers: philipmjackson Tags: #touches_jetpack_files Differential Revision: D70637-code This commit syncs r235663-wpcom.
9a3d668
to
7f85545
Compare
* master: (22 commits) Update storybook monorepo to v6.4.0 (#21897) Refresh the site's modules and settings after successful product activation (#21886) Plugin Install: Bump MC stat on success or fail. (#21893) Nav Unification: Use correct user capability for the Inbox menu item (#21882) Jetpack: Extend disconnection dialog component to handle multiple steps and accept more props (#21048) Disable CSSTidy property shorthand optimization in the editor or headstart (#21891) Connection UI: Update Composer instructions in README.md (#21890) Partner Compatibility: Adding a unique connection screen for customers who receive a coupon from a Jetpack partner (#21813) Search package: move search dashboard to package - the base (#21865) JITM: wrap CTA below text on small viewports (#21688) Licensing JS Package – fix icon positioning and width (#21878) JITM: new JS and CSS builder (#21874) Support site_intent for `/me/sites` endpoint (#21880) Don't render Critical CSS while generating CritCSS. (#21879) ConnectScreen: make button full width on small screens (#21683) Improve the copy of the license activation banner (#21876) Rename Webpack-built files back from `.min.js` and remove hashes (#21748) Search: Migrate more helper classes to package (#21751) Search: migrate/add search rest API (#21584) Add initial state to the connection package (#21864) ...
Summary:
As we need to show different support articles according to the site intent, add
site_intent
into options list so that we can query from the/me/sites
endpointRelated to Automattic/wp-calypso#58486
Test Plan:
/me/sites?fields=options&options=site_intent
site_intent
Also, you can follow the testing instructions from Automattic/wp-calypso#58486
Reviewers: #ganon_team, philipmjackson
Reviewed By: #ganon_team, philipmjackson
Subscribers: philipmjackson
Tags: #touches_jetpack_files
Differential Revision: D70637-code
This commit syncs r235663-wpcom.
Fixes #
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: