Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RePublicize: Enable the block editor UI by default #21855

Merged
merged 3 commits into from
Nov 23, 2021
Merged

RePublicize: Enable the block editor UI by default #21855

merged 3 commits into from
Nov 23, 2021

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Nov 23, 2021

Changes proposed in this Pull Request:

  • Enable the RePublicize block editor UI by default

RePublicize is an extension of Publicize that lets users on paid plans to re-share their posts whenever they want.

Before this change, Jetpack users could only do so through Calypso.
With this change, the RePublicize UI is added to the block editor's Jetpack Sidebar as well.

Screenshot 2021-11-23 at 12 43 55

Note: we chose to keep the filter defaulting to true instead of removing it in order to be able to selectively turn RePublicize off at will on different environments.

Jetpack product discussion

More info in the CfT: p7DVsv-cZY-p2

Does this pull request change what data or activity we track or use?

No.
RePublicize is simply an extension of Publicize, and it reuses the same data.

Testing instructions:

  • Start with a free Jetpack site.
  • Go to Settings -> Sharing, and turn on "Automatically share your posts to social networks" in the "Publicize connections" section.
  • Click on "Connect your social media accounts" which will send you to Calypso (Tools -> Marketing -> Connections).
  • Connect a social network account in the "Publicize posts" section.
  • Navigate back to the posts list and edit a post (or create one first).
  • Once in the block editor, open the Jetpack sidebar.
  • ⚠️ Make sure there is a "Share this post" section, containing a prompt to upgrade to a paid plan.
  • Upgrade your site to a paid plan (Security or higher).
  • Edit the post again, and open the Jetpack sidebar.
  • ⚠️ Make sure there is a "Share this post" section, containing the connected social network account, a textarea, and a "Share Post" button.
  • Share the post.
  • ⚠️ Make sure the post is shared successfully.
    • A confirmation popup should show up in the bottom left corner of the editor.
    • Check in the connected social network if the post has been shared.

@Copons Copons added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review [Extension] Publicize Block editor plugin labels Nov 23, 2021
@Copons Copons requested a review from a team November 23, 2021 12:45
@Copons Copons self-assigned this Nov 23, 2021
test-case-reminder[bot]
test-case-reminder bot reviewed Nov 23, 2021
View reviewed changes
Copy link

@test-case-reminder test-case-reminder bot left a comment •
edited by Copons
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Gutenberg extensions

  • Use Core's block editor
  • Use latest stable Gutenberg plugin

Blocks

  • Tiled Gallery
  • Business Hours
  • Calendly
  • Form
  • Contact Info
  • Eventbrite
  • Google calendar
  • Mailchimp
  • Map
  • OpenTable
  • Pinterest
  • Podcast player
  • Star rating
  • Recurring Payments
  • Repeat Visitor
  • Revue
  • Simple Payments
  • Slideshow

Extensions

  • Publicize
  • Likes

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello Copons! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70501-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

mmtr
mmtr previously approved these changes Nov 23, 2021
View reviewed changes
@mmtr mmtr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Nov 23, 2021
@mmtr mmtr added this to the jetpack/10.4 milestone Nov 23, 2021
@Copons Copons force-pushed the update/enable-republicize-by-default branch from f7eb0da to eca1319 Compare November 23, 2021 14:42
@jeherve jeherve enabled auto-merge (squash) November 23, 2021 16:28
@jeherve jeherve added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Nov 23, 2021
@jeherve jeherve merged commit e845000 into master Nov 23, 2021
@jeherve jeherve deleted the update/enable-republicize-by-default branch November 23, 2021 16:39
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 23, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D70501-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

davidlonjon added a commit that referenced this pull request Nov 25, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
7b19032 
# By Jeremy Herve (5) and others
# Via GitHub
* master: (26 commits)
  Colors: update Primary green reference to match latest brand book (#21741)
  JS Connection: Moves registerSite logic to the store (#21732)
  Search: Add essential scaffolding for package (#21814)
  Search: avoid registering the widget when the module is not active (#21588)
  Add Video Tracks Support to VideoPress Block (#21578)
  Add deprecated to VideoPress block (#21802)
  Admin Menu: Make API tests compatible with WPCOM (#21850)
  External Media: Short-circuit requests earlier in the stack (#21854)
  Add Busy State to License Activation Flow Button (#21861)
  Fixed an issue with screen resolutions of under 783px that caused the content to not be properly displayed when the nav-unification is expanded on wp-admin. (#21869)
  E2E tests: migrate from Jest to Playwright runner (#21848)
  Update reCAPTCHA constants to match Google's Verbage (#12289)
  JITM: Sideload Jetpack Boost functionality  (#21860)
  Connection: properly add GET-parameters for the `fetchAuthorizationUrl` API call (#21750)
  License Flow: Assorted Styling Improvements (#21859)
  JITM: Sideload Jetpack Backup (#21719)
  Widget Visibility: Apply widget filtering to customizer preview (#21505)
  jetpack: Avoid generating unused JS for static-site-generator assets (#21789)
  Nav Unification: Support absolute URLs in upsell nudges (#21821)
  RePublicize: Enable the block editor UI by default (#21855)
  ...

# Conflicts:
#	projects/plugins/boost/tests/e2e/lib/env/prerequisites.js
#	projects/plugins/boost/tests/e2e/lib/setupTests.js
@jeherve jeherve removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Nov 30, 2021
@jeherve
Copy link
Member

jeherve commented Nov 30, 2021

r235836-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@test-case-reminder test-case-reminder[bot] test-case-reminder[bot] left review comments

@mmtr mmtr mmtr approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@Copons Copons

Labels
[Extension] Publicize Block editor plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Copons @matticbot @jeherve @mmtr