[RNMobile] Tiled Gallery Block: Update placeholder text #21620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#4195
With this PR, the placeholder text is changed from "ADD IMAGE" to "ADD MEDIA". This is to bring consistency with the text that's seen in other, similar blocks, such as the Gallery and Story blocks.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4194
Changes proposed in this Pull Request:
instructions
prop is used to update the block's default placeholder text. This matches up with how the placeholder text is set here in the Story block.Jetpack product discussion
Main project thread for the Tiled Gallery block on mobile: p9ugOq-1Tb-p2
Does this pull request change what data or activity we track or use?
No, it doesn't.
Testing instructions:
With these branches checked out and the Gutenberg Mobile demo app running, add the Tiled Gallery block. The placeholder text can be found within the default, empty block. It should be verified that the text reads "ADD MEDIA".