-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing Jetpack plugin JS Tests #20522
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested well for me. Jetpack plugin js tests failed on master, but complete successfully on this PR
The same person answered both questions! Kudos! |
I think we'll need to manually get the lock file back working on WP.com, but this will unblock master. Thank you! |
Caution: This PR has changes that must be merged to WordPress.com |
r229749-wpcom |
Thanks Jeremy! |
Following on from #20512 which introduced Jetpack Boost, it appears that the Jetpack plugin JS tests have been failing (for extensions / blocks in particular). This seems to be to do with a version mismatch between the Jest version that the Jetpack plugin / Jetpack extensions tests were expecting and the one that was running. This PR updates the Jest dependency for the Jetpack plugin to > 27.
The helpful links I found while investigating the failing tests were:
Screenshots
Before:
After:
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
projects/plugins/jetpack
and runpnpm test-extensions
to run tests. Check that they pass!