Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Jetpack plugin JS Tests #20522

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

andrewserong
Copy link
Member

Following on from #20512 which introduced Jetpack Boost, it appears that the Jetpack plugin JS tests have been failing (for extensions / blocks in particular). This seems to be to do with a version mismatch between the Jest version that the Jetpack plugin / Jetpack extensions tests were expecting and the one that was running. This PR updates the Jest dependency for the Jetpack plugin to > 27.

The helpful links I found while investigating the failing tests were:

Screenshots

Before:

image

After:

image

Changes proposed in this Pull Request:

  • Update Jest dependency for the Jetpack plugin to fix failing JS tests

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • See if the CI JS test jobs complete, or to test locally:
  • Go to projects/plugins/jetpack and run pnpm test-extensions to run tests. Check that they pass!
  • Check that this hasn't caused any other tests / jobs to fail

@andrewserong andrewserong self-assigned this Aug 2, 2021
@andrewserong andrewserong requested a review from a team August 2, 2021 05:40
@github-actions github-actions bot added [Block] Latest Instagram Posts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: August 3, 2021.
  • Scheduled code freeze: July 26, 2021.

Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested well for me. Jetpack plugin js tests failed on master, but complete successfully on this PR

@glendaviesnz glendaviesnz added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Aug 2, 2021
@ramonjd
Copy link
Member

ramonjd commented Aug 2, 2021

The helpful links I found while investigating the failing tests were:

The same person answered both questions! Kudos!

@kraftbj
Copy link
Contributor

kraftbj commented Aug 2, 2021

I think we'll need to manually get the lock file back working on WP.com, but this will unblock master. Thank you!

@kraftbj kraftbj merged commit b3c67be into master Aug 2, 2021
@kraftbj kraftbj deleted the fix/failing-jetpack-plugin-js-tests branch August 2, 2021 07:10
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 2, 2021
@github-actions github-actions bot added this to the jetpack/10.0 milestone Aug 2, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello andrewserong! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D65090-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve
Copy link
Member

jeherve commented Aug 3, 2021

r229749-wpcom

@andrewserong
Copy link
Member Author

Thanks Jeremy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Instagram Posts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants