-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSSTidy: preserve leading decimal zeros in Gutenberg #19993
CSSTidy: preserve leading decimal zeros in Gutenberg #19993
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
projects/plugins/jetpack/tests/php/modules/csstidy/test-class.jetpack-csstidy.php
Outdated
Show resolved
Hide resolved
Adds a setting to csstidy to tell the optimizer to preserve leading decimal zeros. For Gutenberg inline styles, `0.7` is a valid CSS value for line-height for example. CSSTidy "optimizes" this to remove the leading zero resulting in `.7`. This triggers block validation errors.
Updating tests.
Added further test cases
5d5261e
to
a816cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well for me on sandbox. I couldn't get the unit tests to run locally, they gave a 'Cannot open file "csstidy.php".' error, but running on CI, so assume there is something broken in my local setup.
…config-setting-to-preserve-leading-decimal-zero
Great news! One last step: head over to your WordPress.com diff, D62096-code, and commit it. Thank you! |
r227276-wpcom |
Fixes Automattic/wp-calypso#45629
Changes proposed in this Pull Request:
CSSTidy performs some "optimizations" that trigger Gutenberg block validation errors.
To prevent this, we've had to add some "optimizations" of our own to CSSTidy's inner workings. See, for example,
#19935
This PR adds a setting to CSSTidy to tell its optimizer to preserve leading decimal zeros.
Currently, CSSTidy strips the
0
from0.7
resulting in.7
.For Gutenberg inline styles,
0.7
is a valid CSS value for line-height for example. Where the post body content contains.7
, we see block validation errors 😱TODO
Does this pull request change what data or activity we track or use?
Nope.
Testing instructions:
Patch your sandbox with the diff created by this PR
Create a paragraph or heading block and select a line-height value of less than
0
Save the post and refresh the page.
You should not see any validation errors, e.g.,
Unit tests
Run
yarn docker:up
from the Jetpack repo root directory.In another terminal run
yarn run docker:phpunit --testsuite csstidy
.