-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP.com Posts: Show thumbnail on the posts list screen #19777
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
@@ -0,0 +1,14 @@ | |||
This program is free software; you can redistribute it and/or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't typically added licenses to our packages until now, but you make a good point. I've asked in p2y3YZ-4v3-p2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this was added by the Generate Wizard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems @sdixon194 planned for it already 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"minimum-stability": "dev", | ||
"prefer-stable": true, | ||
"extra": { | ||
"mirror-repo": "Automattic/jetpack-wpcom-posts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be okay to enable autotagger for this package.
"mirror-repo": "Automattic/jetpack-wpcom-posts", | |
"autotagger": true, | |
"mirror-repo": "Automattic/jetpack-wpcom-posts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know about that, thanks! I guess we can maybe include an additional step in the Generate Wizard asking about this option, so it increases the visibility of this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdixon194 Do you think we could add this to the generate
command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, we can do that! Opened an issue to track it here: #19816
@@ -0,0 +1,21 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is something that should be within the Jetpack plugin instead, or within wpcomsh, and then this package would only be the package itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or something that is used with the Config package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to leave this out of the Jetpack plugin for various reasons:
- This is part of a technical spike exploring how we can build a package which will be exclusively consumed by WP.com Simple and Atomic sites.
- I don't see a clear fit for this feature in Jetpack (especially after branding it as a solution for Security, Backups, Performance, and Growth). Even if we decide there is a fit, there is not certainty that all future features that will be bundled in this package may fit.
I do see value in setting up this via the Config package (which will be done on the WP.com sites), so I'll explore that approach.
Putting this on hold, since we decided to stop investigating this approach in order to better assign our resources during the next 3 months. Further reading: pd2C0z-b-p2#comment-23 |
Closing this for now because of the lack of activity on this. We can always reopen in the future if needed. |
Changes proposed in this Pull Request:
wpcom-posts
package which seeks to be home for all the enhancements to apply on the Posts and Pages screens for WordPress.com sites.Remaining tasks:
Jetpack product discussion
pd2C0z-b-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
cd projects/plugins/jetpack && composer require automattic/jetpack-wpcom-posts
.