Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check .nvmrc versus package.json engines #19750

Merged
merged 3 commits into from
May 14, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented May 5, 2021

Changes proposed in this Pull Request:

Check that the node version in .nvmrc matches the version required by
.engines.node in package.json in CI.

Jetpack product discussion

Came up in passing in review of #19705.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is CI happy?
  • Try changing the versions to not match. Is that caught?

@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels May 5, 2021
@anomiex anomiex self-assigned this May 5, 2021
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kraftbj kraftbj enabled auto-merge (squash) May 14, 2021 20:33
@kraftbj kraftbj merged commit 520ab13 into master May 14, 2021
@kraftbj kraftbj deleted the add/ci-check-nvmrc-vs-package.json branch May 14, 2021 20:35
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants