Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for wp-env database issue #19151

Merged
merged 7 commits into from
Mar 16, 2021
Merged

Conversation

adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented Mar 12, 2021

This is a temp solution for wp env database connection issue

Changes proposed in this Pull Request:

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

yarn install
yarn wp-env destroy
yarn wp-env start

WP env should start successfully.

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@adimoldovan adimoldovan changed the title Add WP version in wp-ev configuration Temporary fix for wp-env database issue Mar 16, 2021
@adimoldovan adimoldovan marked this pull request as ready for review March 16, 2021 11:22
@adimoldovan adimoldovan self-assigned this Mar 16, 2021
@adimoldovan adimoldovan requested a review from brbrr March 16, 2021 11:31
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the change to wp-setup it works well for me locally. Lets merge it once CI is green

@adimoldovan adimoldovan merged commit b1280f7 into master Mar 16, 2021
@adimoldovan adimoldovan deleted the fix/e2e-fix-wp-env-57 branch March 16, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants