Fix instagram infinite loop bug

[glendaviesnz]

Changes proposed in this Pull Request:

• Removes notices dependency as this is causing an infinite rerender issue withNotices: Ensure that the callback props are stable. WordPress/gutenberg#29491. This gutenberg patch doesn't fix the issue for the Instagram block, as it used noticeOperations instead of createErrorNotice as a dependency.

Jetpack product discussion

Primary issue: #19038

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Add instagram latest posts block along with latest gutenberg plugin release and make sure block operates as normal

Proposed changelog entry for your changes:

• Removes the notices dependency in the customhook useEffect as changes in the notices dependency shouldn't cause the api calls to rerun.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello glendaviesnz! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D58161-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Include a changelog entry for any meaningful change.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined

---

jetpack plugin:

• Next scheduled release: April 6, 2021.
• Scheduled code freeze: March 29, 2021

[glendaviesnz]

@jeherve, fyi this was an urgent bug fix and the wpcom diff has bee deployed by @fullofcaffeine

[jeherve]

This tests well for me. Merging.

[jeherve]

r222177-wpcom

[jeherve]

Cherry-picked to jetpack/branch-9.5 in 5583f8d