Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhatsApp: Adjust menu size and remove some settings from block menu #18732

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Feb 5, 2021

Fixes 212-gh-Automattic/view-design
Fixes #18645

Changes proposed in this Pull Request:

  • Restores min-width for the block toolbar menu on the Whatsapp block
  • Removes the Default First Message and Open In New Tab settings from the block toolbar menu; they are kept in the Inspector Controls.

Before:
Screen Shot 2021-02-05 at 2 56 44 PM

After:
Screen Shot 2021-02-05 at 2 58 57 PM

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Add a WhatsApp block to a new post
  • Open the WhatsApp button settings from the block toolbar and verify that it only contains the Phone Number setting, and that the menu is the correct size
  • Open the Inspector Controls for the WhatsApp block and verify that the Default First Message and Open In New Tab settings are still present

Proposed changelog entry for your changes:

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello stacimc! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D56601-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against f4ca61c

@stacimc stacimc requested a review from a team February 6, 2021 00:18
@stacimc stacimc added [Block] Send a message [Type] Bug When a feature is broken and / or not performing as intended labels Feb 6, 2021
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

This is working well and looking much better.

  • Block and block settings still function correctly
  • Block toolbar menu now has the correct min-width
  • Block toolbar menu only displays phone number field
  • Inspector controls still contain default first message and open-in-new-tab setting

Screen Shot 2021-02-08 at 10 38 49 am

@aaronrobertshaw aaronrobertshaw added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Feb 8, 2021
@jeherve jeherve added this to the 9.5 milestone Feb 8, 2021
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 8, 2021
@stacimc stacimc merged commit 9022260 into master Feb 8, 2021
@stacimc stacimc deleted the fix/whatsapp-block-menu-sizing branch February 8, 2021 23:43
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 8, 2021
@apeatling
Copy link
Member

@stacimc Can we merge this diff on WordPress.com before the Jetpack release please?

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello stacimc! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D57157-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

glendaviesnz pushed a commit that referenced this pull request Feb 17, 2021
@jeherve
Copy link
Member

jeherve commented Feb 17, 2021

r220769-wpcom

jeherve added a commit that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Send a message Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WhatsApp Button: block settings popover with narrow width
6 participants