Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: add block enqueuing methods #17262

Closed
wants to merge 1 commit into from
Closed

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 25, 2020

Changes proposed in this Pull Request:

  • Add methods allowing to enqueue assets for Jetpack blocks and standalone blocks.
  • This PR does not switch existing blocks to use the new method; this will be done in a follow-up PR.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Do the tests pass?

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Package] Blocks labels Sep 25, 2020
@jeherve jeherve self-assigned this Sep 25, 2020
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Sep 25, 2020
@jeherve jeherve marked this pull request as draft September 25, 2020 11:23
@jetpackbot
Copy link

jetpackbot commented Sep 25, 2020

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17262

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 715638f

@jeherve jeherve force-pushed the add/blocks-package-enqueue branch from 3277468 to 715638f Compare October 22, 2020 17:09
@jeherve
Copy link
Member Author

jeherve commented Jan 31, 2022

Closing this for now, since I haven't been able to work on it in the past few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Blocks [Pri] Normal [Status] Needs Package Release This PR made changes to a package. Let's update that package now. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants