-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WooCommerce Analytics: make it available as module #15187
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 7, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me. Although I wasn't able to get new parameters as explained in #15127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed this is all working well:
- Woo analytics can be enabled and disabled.
- Woo analytics only sends events when it is enabled.
- Woo analytics is unavailable and disabled when Woo plugin is not active.
I noticed that woo analytics module was disabled by default – when active Jetpack is updated to the version with the module, or after Jetpack is freshly activated. Is this as expected – is my dev setup or some config on my end breaking this somehow?
Ah I see – to test activation by default, I'd need to simulate updating from 8.3 => 8.4, by changing the version number. Or, test the beta build which will be available soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeherve this is looking great and testing well for me! I can toggle on/off and see the effect on requests for t.gif
.
Activate WooCommerce. You should see the module available and active.
The module isn't active by default for me, I have to click "Activate" after re-activating WooCommerce.
On a site that does not run WooCommerce
I only de-activated instead of deleting or running on a site that never had Woo. Perhaps that is the reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I read previous comments here and p7Ldg5-ru-p2. Sounds good to me 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Changes proposed in this Pull Request:
WooCommerce Analytics was always enabled until now, and could not be disabled unless you were to hook into
jetpack_tools_to_include
.This PR makes the feature a proper module.
jetpack_get_default_modules
.wp-admin/admin.php?page=jetpack_modules
)Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
wp-admin/admin.php?page=jetpack_modules
; you should see the module greyed out.Proposed changelog entry for your changes: