-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscriptions block updates #15107
Subscriptions block updates #15107
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Status so far:
In terms of styling I also think there needs to be control of:
/cc @mtias |
Nice work!
I think this should be a single control that always applies to both the button and the input to make it feel in concert. |
I guess with the submit button being a "shared" resource we need to check impact on other blocks consuming it. |
Thanks! Will review this feedback this afternoon. With all the shared button changes the other blocks will definitely need an update, I can handle this once all the changes to this block are done. If it ends up being a large amount of work, I can separate the button changes and work on that in a different PR. |
I've now switched this to not use the shared submit button. Instead using standard controls and bringing the settings into the actual block itself. Styles are passed through and applied to both elements. |
This is an automated check which relies on |
Range control components don't seem to work correctly on zero values. For example try the buttons block and drag the border radius slider to zero. The value in the textfield remains at 5? The actual border radius is set as zero though. Known bug? |
Mmm, yes, I'm seeing the same issue. Perhaps related to: WordPress/gutenberg#20247 |
…er's website until they have at least one subscriber.
70d499a
to
11a3943
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving once again after a rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed a commit in my last rebase.
🎉 |
I've noticed that this PR hasn't been synced to WPCOM yet! |
Will do this later today 👍 |
r208345-wpcom |
I came to the repo to submit a feature request, and here it is already done. ❤️ |
Update the email subscription block to significantly improve the settings for customizing the display and style of the form.
Fixes #15076
Testing instructions:
To test old blocks:
Proposed changelog entry for your changes: