Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendly Block: Show an error when the embed url is not found #14814

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Calendly Block: Show an error when the embed url is not found #14814

merged 4 commits into from
Mar 17, 2020

Commits on Mar 5, 2020

  1. Resolve the embed URL before embedding it

    @Copons
    Copons committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    e9f111d View commit details
    Browse the repository at this point in the history

  2. Stop resolving the example url

    @Copons
    Copons committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    abc2bdf View commit details
    Browse the repository at this point in the history

  3. Only automatically resolve the URL on block mount

    @Copons
    Copons committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    84d25ef View commit details
    Browse the repository at this point in the history

  4. Create a testEmbedUrl utility to handle the resolve-redirect check on… 

    … embed URLs
    @Copons
    Copons committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    26fafa2 View commit details
    Browse the repository at this point in the history