Masterbar: Update the Reader link

[ramonjd]

Fixes N/A

Changes proposed in this Pull Request:

We're updating the masterbar Reader link to explicitly go to wordpress.com/read

For background context, we'd like to set up an A/B test to redirect a (logged-in) test group to Customer Home instead of the Reader upon visiting wordpress.com

In order to achieve that we need to ensure we can manipulate the default landing page for /. Currently it is /read.

By updating instances of / to /read, we'll ensure that links to the Reader work regardless of which A/B test cohort the clicker is in.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

For context see:

• p58i-89H-p2
• EPIC Issue: https://github.com/Automattic/zelda-private/issues/173
• Calypso PR: Move the Reader from / to /read wp-calypso#37547

Testing instructions

• Connect your local ngroked Jetpack application to a wordpress.com site
• Visit http://{yoursiteurl}/wp-admin/plugins.php?calypsoify=1
• The Reader link in the masterbar should link to https://wordpress.com/read

• Now enable the WordPress.com toolbar

• The Followed Sites link in the sidebar should link to https://wordpress.com/read

Proposed changelog entry for your changes:

• Updated the link to the Reader in the masterbar to point to https://wordpress.com/read

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against 018e43a

[andrewserong]

Thanks for working on this one @ramonjd! Tested in my local Jetpack dev environment, and the masterbar Reader button now links through to https://wordpress.com/read.

Still might just want a review from @Automattic/jetpack-crew too, to see about getting this in the next release :)

[kbrown9]

This looks good to me! I tested the change, and the Reader link in the masterbar links to https://wordpress.com/read.

[jeherve]

This works for me, but I wonder if we shouldn't also change the Reader link in the regular Masterbar, displayed to everyone even when Calypsoify is off:

jetpack/modules/masterbar/masterbar.php

Line 407 in cd17208

'href' => '#',

Or do we want those folks to keep using the old link?

[ramonjd]

This works for me, but I wonder if we shouldn't also change the Reader link in the regular Masterbar, displayed to everyone even when Calypsoify is off:

Thanks @jeherve Totally missed that. All links to the Reader, whose underlying URL is wordpress.com should be switched to wordpress.com/read.

I'll take a look and change appropriately tomorrow.

[jeherve]

Thanks for the confirmation! I updated the link for you, this should now be good to merge!

[ramonjd]

Thanks for the confirmation! I updated the link for you, this should now be good to merge!

Thanks @jeherve ! I updated the test instructions anyway since it took me a while to work out where I should be seeing this link :)