-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests: switch to PHP 7.4 Production #14171
Conversation
E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-14171 This is an automated check which relies on |
Couple of tests are failing in 7.4, but sounds like issues with the tests themselves.
|
7e21a75
to
0bc7f3d
Compare
I updated #13773 to give us a playground to work on this test. |
819d459
to
7ab5fef
Compare
It turns out PHP 7.4 is not yet ready for Ubuntu Trusty (14.04) on Travis. Work is in progress here: Putting this PR on hold for now. |
Alternatively, we can explore not using Trusty. An initial test led to a lot more failures, so we can examine that on it's own and not within the context of this PR if php-build's work beats us to it. |
7ab5fef
to
24cb300
Compare
24cb300
to
dfd9222
Compare
We're still running into the same issues as in #14171
* General: update minimum WordPress version for Jetpack WordPress 5.4 is scheduled for release before the next version of Jetpack will ship. Let's consequently aim to update Jetpack to keep our WP-1 support standard. * Remove temporary workarounds now that all Jetpack users use WP5.3+ Also update date() into gmdate() as per WordPress coding standards changes. * Related Posts: remove workaround that is not necessary anymore * Revert Travis changes for now We're still running into the same issues as in #14171 * Force all "Previous" WP version tests to be 5.3 for now We can move back to "previous" once WP 5.4 has shipped
This PR has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
20749ae
to
26550ca
Compare
Still fiddling with it. When I dump the value, it is there, but obviously is sometimes a class instead of an array. I added some json encoding/decoding to standardize everything as an array, but still instances of Core not returning what we'd expect. This isn't an unit test failure as much as an integration test failure, but still not sure what's happening yet. |
18a68a5
to
a8a7ea3
Compare
24f7a90
to
386fcf9
Compare
386fcf9
to
69a56a3
Compare
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: