Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yarn script to run test for multisite #12010

Merged
merged 4 commits into from
Apr 15, 2019
Merged

Add yarn script to run test for multisite #12010

merged 4 commits into from
Apr 15, 2019

Conversation

enejb
Copy link
Member

@enejb enejb commented Apr 10, 2019 •
edited by oskosk
Loading

Adds yarn docker:phpunit:multisite command that lets us run the wordpress multisite test suite much easier on the docker development.

Changes proposed in this Pull Request:

  • Adds yarn docker:phpunit-mu command that lets us run the wordpress multisite test suite much easier on the docker development.

Testing instructions:

  • Start up the docker dev enviroment.
  • run yarn docker:phpunit:multisite --filter=test_full_sync_sends_only_current_blog_users_in_multisite
  • are the multi site test skipped or are they runnning as expected?

Proposed changelog entry for your changes:

  • New yarn command to run the multi site phpunit suite yarn docker:phpunit-mu

@enejb enejb added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Docker labels Apr 10, 2019
@enejb enejb requested review from oskosk and a team April 10, 2019 18:27
@enejb enejb self-assigned this Apr 10, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello enejb! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26753-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Apr 10, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 29, 2019.
Scheduled code freeze: April 22, 2019

Generated by 🚫 dangerJS against 8e61f60

oskosk
oskosk reviewed Apr 11, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
oskosk
oskosk previously requested changes Apr 11, 2019
View reviewed changes
docker/README.md Outdated Show resolved Hide resolved
@oskosk oskosk added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 11, 2019
@matticbot
Copy link
Contributor

enejb, Your synced wpcom patch D26753-code has been updated.

enejb
enejb commented Apr 11, 2019
View reviewed changes
Copy link
Member Author

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made all the changes to as requested.

docker/README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
enejb
enejb commented Apr 11, 2019
View reviewed changes
Copy link
Member Author

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made all the changes to as requested.

@enejb enejb added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 11, 2019
@oskosk oskosk changed the title Update/yarn command to run multisite tests Add yarn script to run test for multisite Apr 11, 2019
@jeherve jeherve dismissed oskosk’s stale review April 15, 2019 11:11

Feedback addressed

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 15, 2019
jeherve
jeherve approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well for me. 👍

@jeherve jeherve added this to the 7.3 milestone Apr 15, 2019
@zinigor zinigor merged commit 2916d6b into master Apr 15, 2019
@zinigor zinigor deleted the update/yarn-command-to-run-multisite-tests branch April 15, 2019 13:03
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@oskosk oskosk oskosk left review comments

Assignees

@enejb enejb

Labels
Docker Touches WP.com Files
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
7 participants
@enejb @matticbot @jetpackbot @jeherve @oskosk @kraftbj @zinigor