Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devicepx-jetpack.js #820

Closed
enejb opened this issue Jul 10, 2014 · 8 comments
Closed

Remove devicepx-jetpack.js #820

enejb opened this issue Jul 10, 2014 · 8 comments
Labels
[Closed] Duplicate Duplicate of an existing issue. [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Pri] Low [Status] Proposal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@enejb
Copy link
Member

enejb commented Jul 10, 2014

Currently 'devicepx-jetpack.js' called the zoomImages function every second.
How can we improve this function?

@blobaugh
Copy link
Contributor

@enejb take a gander at https://plugins.trac.wordpress.org/ticket/2031 for an in-depth post by @tollmanz

@jeherve
Copy link
Member

jeherve commented Jul 11, 2014

I closed the old trac ticket. Let's continue the discussion here.

@kasparsd
Copy link
Contributor

This is a very serious issue because it's forcing the browser to recalculate and redraw the whole layout in case of Safari. Here is the sequence of events:

jetpack-zoomimages-recalc

and here is the offending part:

jetpack-changing-dom

which is called every second as @enejb mentioned:

jetpack-zoomimages-loop

@kraftbj
Copy link
Contributor

kraftbj commented Jan 24, 2016

I'd like us to look at devicepx-jetpack.js overall. Now that Photon supports responsive imaging, how useful is devicepx? Can we reduce/drop usage of devicepx in addition to making this more efficient.

@jeherve jeherve modified the milestones: 4.0, Needs Triage Feb 16, 2016
@jeherve jeherve modified the milestones: 4.1, 4.3 Jun 17, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@jeherve jeherve modified the milestones: 4.4, Not Currently Planned Oct 27, 2016
@stale
Copy link

stale bot commented Jul 7, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Jul 7, 2018
@stefenphelps
Copy link

I agree with @kraftbj, there is no need for devicepx.js anymore now that there is broad support for responsive images.

@stale stale bot removed the [Status] Stale label Sep 19, 2018
@BrookeDot
Copy link
Contributor

BrookeDot commented Sep 19, 2018

I'll go ahead and re-name this issue "Remove Device devicepx-jetpack.js" Since that sounds like the desired result for this issue.

I would recommend perhaps making the script still filterable but not loaded by default. For example something like add_filter( 'Jetpack_devicepx', true, 10 ); would still load the script.

@BrookeDot BrookeDot changed the title Improvements to the devicepx js Remove devicepx-jetpack.js Sep 19, 2018
@jeherve jeherve added the [Closed] Duplicate Duplicate of an existing issue. label Sep 20, 2018
@jeherve
Copy link
Member

jeherve commented Sep 20, 2018

I would recommend perhaps making the script still filterable but not loaded by default.

That's the approach we discussed in #1850. I'm going to close this issue as duplicate, since they're mostly the same now.

@jeherve jeherve closed this as completed Sep 20, 2018
leogermani pushed a commit that referenced this issue Aug 12, 2022
* Bump version to 1.7.8 and update changelog

* Add hash of check in

* Remove )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Duplicate Duplicate of an existing issue. [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Pri] Low [Status] Proposal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

9 participants