-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove devicepx-jetpack.js #820
Comments
@enejb take a gander at https://plugins.trac.wordpress.org/ticket/2031 for an in-depth post by @tollmanz |
I closed the old trac ticket. Let's continue the discussion here. |
This is a very serious issue because it's forcing the browser to recalculate and redraw the whole layout in case of Safari. Here is the sequence of events: and here is the offending part: which is called every second as @enejb mentioned: |
I'd like us to look at devicepx-jetpack.js overall. Now that Photon supports responsive imaging, how useful is devicepx? Can we reduce/drop usage of devicepx in addition to making this more efficient. |
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
I agree with @kraftbj, there is no need for devicepx.js anymore now that there is broad support for responsive images. |
I'll go ahead and re-name this issue "Remove Device devicepx-jetpack.js" Since that sounds like the desired result for this issue. I would recommend perhaps making the script still filterable but not loaded by default. For example something like |
That's the approach we discussed in #1850. I'm going to close this issue as duplicate, since they're mostly the same now. |
* Bump version to 1.7.8 and update changelog * Add hash of check in * Remove )
Currently 'devicepx-jetpack.js' called the zoomImages function every second.
How can we improve this function?
The text was updated successfully, but these errors were encountered: