Fix incorrect usage of publicize config in subscribe block (#40355)

* Fix incorrect usage of publicize config in subscribe block * Fix unit tests
Automattic · Nov 27, 2024 · f9a3dc7 · f9a3dc7
1 parent f9382e2
commit f9a3dc7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/projects/plugins/jetpack/changelog/fix-incorrect-usage-of-publicize-in-subscribe-block b/projects/plugins/jetpack/changelog/fix-incorrect-usage-of-publicize-in-subscribe-block
@@ -0,0 +1,4 @@
+Significance: patch
+Type: bugfix
+
+Fixed block error when editing Subscribe block
diff --git a/projects/plugins/jetpack/extensions/blocks/subscriptions/controls.js b/projects/plugins/jetpack/extensions/blocks/subscriptions/controls.js
@@ -1,6 +1,5 @@
 import { numberFormat } from '@automattic/jetpack-components';
-import { usePublicizeConfig } from '@automattic/jetpack-publicize-components';
-import { isSimpleSite } from '@automattic/jetpack-shared-extension-utils';
+import { isSimpleSite, useModuleStatus } from '@automattic/jetpack-shared-extension-utils';
 import {
 	ContrastChecker,
 	PanelColorSettings,
@@ -56,7 +55,7 @@ export default function SubscriptionControls( {
 	subscribePlaceholder = DEFAULT_SUBSCRIBE_PLACEHOLDER,
 	successMessage = DEFAULT_SUCCESS_MESSAGE,
 } ) {
-	const { isPublicizeEnabled } = usePublicizeConfig();
+	const { isModuleActive: isPublicizeEnabled } = useModuleStatus( 'publicize' );
 
 	return (
 		<>

diff --git a/projects/plugins/jetpack/extensions/blocks/subscriptions/test/controls.js b/projects/plugins/jetpack/extensions/blocks/subscriptions/test/controls.js
@@ -36,6 +36,17 @@ afterAll( () => {
 
 jest.mock( '@wordpress/notices', () => {}, { virtual: true } );
 
+jest.mock( '@automattic/jetpack-shared-extension-utils', () => ( {
+	__esModule: true,
+	...jest.requireActual( '@automattic/jetpack-shared-extension-utils' ),
+	useModuleStatus: jest.fn().mockReturnValue( {
+		isModuleActive: true,
+		isLoadingModules: false,
+		isChangingStatus: false,
+		changeStatus: jest.fn(),
+	} ),
+} ) );
+
 const setButtonBackgroundColor = jest.fn();
 const setGradient = jest.fn();
 const setTextColor = jest.fn();
@@ -74,13 +85,6 @@ beforeEach( () => {
 } );
 
 describe( 'Inspector controls', () => {
-	beforeEach( () => {
-		window.JetpackScriptData = {
-			social: {
-				urls: {},
-			},
-		};
-	} );
 	describe( 'Gradient settings panel', () => {
 		test( 'displays gradient settings control panel', () => {
 			render( <SubscriptionsInspectorControls { ...defaultProps } /> );