Jetpack: Fix a legacy-full-sync test with PHPUnit 9.5 (#22112)

At some point PHPUnit changed `assertContains()` to do strict comparison. Now that we're running the coverage tests with PHP 8 and PHPUnit 9.5, a test was failing due to string vs int comparison. Co-authored-by: Brandon Kraft <[email protected]>
Automattic · Dec 15, 2021 · c18c518 · c18c518
1 parent e087309
commit c18c518
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/projects/plugins/jetpack/changelog/fix-jetpack-legacy-full-sync-test-php-8 b/projects/plugins/jetpack/changelog/fix-jetpack-legacy-full-sync-test-php-8
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Fix a legacy sync test in PHPUnit 9.5.
diff --git a/projects/plugins/jetpack/tests/php/sync/test_class.jetpack-sync-full.php b/projects/plugins/jetpack/tests/php/sync/test_class.jetpack-sync-full.php
@@ -1267,7 +1267,7 @@ function test_full_sync_can_sync_individual_comments() {
 		$comments = $synced_comments_event->args[0];
 
 		$this->assertEquals( 2, count( $comments ) );
-		$comment_ids = array( $comments[0]->comment_ID, $comments[1]->comment_ID );
+		$comment_ids = array( (int) $comments[0]->comment_ID, (int) $comments[1]->comment_ID );
 
 		$this->assertContains( $sync_comment_id, $comment_ids );
 		$this->assertContains( $sync_comment_id_2, $comment_ids );