Fix underlined links inside boxes (#39337)

* Remove underline from external links in boxes * changelog * Update changelog * Fix margin issue for full-width plan feature card
Automattic · Sep 11, 2024 · 1d28331 · 1d28331
1 parent 8de48fd
commit 1d28331
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 7 deletions.
diff --git a/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss b/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss
@@ -239,7 +239,9 @@
 	margin-bottom: 0;
 
 	a.dops-section-nav-tab__link {
-		text-decoration: none;
+		span.components-external-link__contents {
+			text-decoration: none;
+		}
 	}
 
 	@include breakpoint( ">660px" ) {

diff --git a/projects/plugins/jetpack/_inc/client/my-plan/style.scss b/projects/plugins/jetpack/_inc/client/my-plan/style.scss
@@ -164,10 +164,6 @@
 		width: 49.5%;
 	}
 
-	@include breakpoint( ">660px" ) {
-		margin-bottom: 24px;
-	}
-
 	@include breakpoint( "<660px" ) {
 		max-width: 100%;
 		margin-bottom: rem( 8px );
@@ -213,6 +209,10 @@
 	button {
 		font-weight: 500;
 		font-size: var(--font-body-extra-small);
+
+		.components-external-link__contents {
+			text-decoration: none;
+		}
 	}
 }
 
@@ -227,6 +227,7 @@
 	flex-direction: row;
 	align-items: stretch;
 	justify-content: space-between;
+	gap: 24px;
 	margin-bottom: rem( 32px );
 	margin-left: rem( -8px );
 	margin-right: rem( -8px );
@@ -237,8 +238,6 @@
 }
 
 .jp-landing__plan-features-card:nth-child(odd) {
-	margin-right: 24px;
-
 	@include breakpoint( "<660px" ) {
 		margin-right: 8px;
 	}

diff --git a/projects/plugins/jetpack/_inc/client/recommendations/prompts/prompt-layout/style.scss b/projects/plugins/jetpack/_inc/client/recommendations/prompts/prompt-layout/style.scss
@@ -67,6 +67,10 @@
 	a {
 		white-space: nowrap;
 	}
+
+	.components-external-link__contents {
+		text-decoration: none;
+	}
 }
 
 .jp-recommendations-question__description-list {
@@ -191,6 +195,10 @@
 				width: 100%;
 			}
 		}
+
+		.components-external-link__contents {
+			text-decoration: none;
+		}
 	}
 
 	@include breakpoint( '<480px' ) {

diff --git a/projects/plugins/jetpack/_inc/client/recommendations/sidebar/discount-card/style.scss b/projects/plugins/jetpack/_inc/client/recommendations/sidebar/discount-card/style.scss
@@ -98,6 +98,10 @@
 		.components-external-link__icon {
 			margin-left: 4px;
 		}
+
+		.components-external-link__contents {
+			text-decoration: none;
+		}
 	}
 
 	&__timer {

diff --git a/projects/plugins/jetpack/changelog/fix-underlined-links-inside-boxes b/projects/plugins/jetpack/changelog/fix-underlined-links-inside-boxes
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Styles: update styling for external links