Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast session and room changes from sync worker (no encryption yet) #18

Merged
merged 15 commits into from
Apr 11, 2023

Conversation

psrpinto
Copy link
Member

Broadcast session and room-level sync changes from worker to main thread(s).

Encrypted rooms are not yet implemented, that will be addressed in the next PR.

Summary of changes

  1. Introduce a SendQueuePool which allows us to listen to newly-generated events across all rooms. These events are then propagated to the worker. Since "pending events" are handled as part of the sync process, the worker needs to be aware of them so that the sync properly removes them as pending.
  2. Serialize and deserialize sync changes on the worker and in the main thread, respectively.

Screen recordings

Screen.Recording.2023-04-06.at.16.19.18.mov
Screen.Recording.2023-04-06.at.16.53.43.mov

@psrpinto psrpinto self-assigned this Apr 11, 2023
@psrpinto
Copy link
Member Author

I accidentally merged #15 to the wrong branch, this PR is the same as that one but targetting master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync-worker upstream-contribution-candidate Supposed to go to upstream as a PR once base branch is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant