Improve config change handling #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantlemons
reviewed
Nov 27, 2024
|
Looks great @mcecode. I'm impressed that you were able to root through that (admittedly quite messy) file, especially for your first time writing Rust. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that config updates don't get reflected in the editor unless
harper-lsis restarted, at least for VSCode. Hence, my original solution to just restart it, but that feels like such a brute force way and it clears all the diagnostics within the workspace. So, I thought it'd be better if the new config is reflected and the diagnostics are updated whendid_change_configurationis called.P.S. This is my first time writing any Rust so I may have made a mistake somewhere.