Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typst support #230

Open
pinpox opened this issue Oct 17, 2024 · 3 comments
Open

Typst support #230

pinpox opened this issue Oct 17, 2024 · 3 comments
Assignees
@grantlemons

Comments

@pinpox
Copy link

pinpox commented Oct 17, 2024

Similar to #56, I would like to propose support for typst.
There is a pretty good working languageserver for it, in case that helps with implementation.
@elijah-potter
Copy link
Collaborator

Since the Typst parser is actually written in Rust, it should be relatively straightforward to make this happen. It's relatively low priority at the moment though, so unless someone else decides to pick this up, I can't give you a time estimate.

@pinpox
Copy link
Author

pinpox commented Oct 19, 2024

unless someone else decides to pick this up, I can't give you a time estimate.

Would you be able to provide some guidance? I might find the time to submit a PR but don't really know where to start. Maybe there is some similar example ?

@elijah-potter
Copy link
Collaborator

You'll want to look at harper-core/src/parsers/Markdown. That's the implementation that wraps pulldown-cmark. You'll likely want to make a copy and swap out the innards for the Typst parser (which I believe is just a crate).

grantlemons added a commit that referenced this issue Nov 25, 2024
@grantlemons
feat(#230): map basic typst expressions to tokens
9211597
@grantlemons grantlemons self-assigned this Nov 25, 2024
grantlemons added a commit that referenced this issue Nov 25, 2024
@grantlemons
feat(#230): change recursive shorthand from macro to function
fd05b6a
grantlemons added a commit that referenced this issue Nov 26, 2024
@grantlemons
feat(#230): flesh out more complicated typst syntax parsing
920ee0a
grantlemons added a commit that referenced this issue Nov 26, 2024
@grantlemons
feat(#230): delegate typst files to parser in harper-cli and harper-ls
e974fe6
grantlemons added a commit that referenced this issue Nov 26, 2024
@grantlemons
fix(#230): fix offset update after delegating parser
b283ce4
grantlemons added a commit that referenced this issue Nov 26, 2024
@grantlemons
fix(#230): ParBreak to ParBreak, not two Newlines
dac8c7c
grantlemons added a commit that referenced this issue Nov 26, 2024
@grantlemons
feat(#230): remove offset variable, and just use the start of an
9798b8d 
environment's span
grantlemons added a commit that referenced this issue Nov 27, 2024
@grantlemons
feat(#230): parse numbers properly and add test for numbers
ccab586
grantlemons added a commit that referenced this issue Nov 27, 2024
@grantlemons
feat(#230): consolidate words separated by apostrophes into possessiv…
245fb32 
…es or conjunctions
grantlemons added a commit that referenced this issue Nov 27, 2024
@grantlemons
feat(#230): simplify possessive-conjunction logic and add respective …
6ff5fc0 
…tests
@grantlemons grantlemons linked a pull request Nov 28, 2024 that will close this issue
feat: Typst Language Support #289
Closed
grantlemons added a commit that referenced this issue Nov 29, 2024
@grantlemons
feat(#230): create additional parsers for complex dictionary parsing
f5b006b
grantlemons added a commit that referenced this issue Nov 29, 2024
@grantlemons
feat(#230): add some tests for dictionary parsing, and improve dict p…
47be9e6 
…arsing to fit better
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
fix(Automattic#230): fix dict parsing by manually getting document co…
36c7e7f 
…ntent in span so quotes aren't escaped
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
fix(Automattic#230): remove debug print of typst ast in test
a2e1a62
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
style(Automattic#230): expand explainer on str parsing
9a7ae81
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): map basic typst expressions to tokens
aab8edd
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): change recursive shorthand from macro to function
0922632
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): flesh out more complicated typst syntax parsing
55bfcbf
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): delegate typst files to parser in harper-cli an…
376e427 
…d harper-ls
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
fix(Automattic#230): fix offset update after delegating parser
fa322fb
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
fix(Automattic#230): ParBreak to ParBreak, not two Newlines
8fb7707
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): remove offset variable, and just use the start …
1a3c837 
…of an

environment's span
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): parse numbers properly and add test for numbers
2aad44f
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): consolidate words separated by apostrophes into…
fb23a28 
… possessives or conjunctions
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): simplify possessive-conjunction logic and add r…
816dbe0 
…espective tests
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): create additional parsers for complex dictionar…
bdbc258 
…y parsing
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
feat(Automattic#230): add some tests for dictionary parsing, and impr…
b07b83a 
…ove dict parsing to fit better
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
fix(Automattic#230): fix dict parsing by manually getting document co…
8790caf 
…ntent in span so quotes aren't escaped
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
fix(Automattic#230): remove debug print of typst ast in test
ef0f2c6
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
@grantlemons
style(Automattic#230): expand explainer on str parsing
6b5d78a
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): map basic typst expressions to tokens
bed51f7
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): change recursive shorthand from macro to function
7201575
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): flesh out more complicated typst syntax parsing
d880613
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): delegate typst files to parser in harper-cli an…
9376e71 
…d harper-ls
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
fix(Automattic#230): fix offset update after delegating parser
749e6dd
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
fix(Automattic#230): ParBreak to ParBreak, not two Newlines
ba3c307
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): remove offset variable, and just use the start …
c6a4d05 
…of an

environment's span
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): parse numbers properly and add test for numbers
0425110
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): consolidate words separated by apostrophes into…
1f43b27 
… possessives or conjunctions
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): simplify possessive-conjunction logic and add r…
4dbc264 
…espective tests
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): create additional parsers for complex dictionar…
f3eda92 
…y parsing
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
feat(Automattic#230): add some tests for dictionary parsing, and impr…
24e0551 
…ove dict parsing to fit better
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
fix(Automattic#230): fix dict parsing by manually getting document co…
c63d41a 
…ntent in span so quotes aren't escaped
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
fix(Automattic#230): remove debug print of typst ast in test
f57d6c2
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 9, 2024
@grantlemons
style(Automattic#230): expand explainer on str parsing
550cf20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grantlemons grantlemons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Typst Language Support Automattic/harper
3 participants
@pinpox @grantlemons @elijah-potter