Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash algorithm to sha256 #1

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

jgcaruso
Copy link

This PR updates the hashing algorithm to sha256 which is now supported by Gravatar.com

This PR is also duplicated in the original repo with the hopes it gets integrated there as well, and updated in NPM. Otherwise, we can use this repo for imports for internal products (like Cloudup)

Testing

  1. pull pr
  2. run the following command to test the exported functions using your email address, and verify that the correct image is displayed in the browser
    • prints gravatar url node -e "var gravatar = require('./index.js'); console.log(gravatar.url('[email protected]'))"
    • prints a valid gravatar url with image size at 20px node -e "var gravatar = require('./index.js'); console.log(gravatar.url('[email protected]', {s: 20}))"

@jgcaruso jgcaruso requested review from pgk and thedebian July 19, 2023 20:53
@jgcaruso jgcaruso self-assigned this Jul 19, 2023
Copy link

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well 👍

Looking for md5 through the code, I think we can remove browser/md5 which references the removed npm package in package.json.
There's also a weird component.json which seems to be a sort of package.json, but not synced with it, I'm not sure what we should do with that.

@jgcaruso
Copy link
Author

jgcaruso commented Jul 26, 2023

Worked well 👍

Looking for md5 through the code, I think we can remove browser/md5 which references the removed npm package in package.json.

Nice catch, don't know how I missed that

There's also a weird component.json which seems to be a sort of package.json, but not synced with it, I'm not sure what we should do with that.

I think this is an attempt at something like npm, or a replacement for it? All these "components" would be downloadable from some central repository. I've seen reference to other components. I don't know what to do with it either because I don't know how to test it. Everything in https://github.com/webmodules/ seems to support this component framework.

Found this link https://github.com/componentjs/component it was abandoned in 2019.

@jgcaruso jgcaruso merged commit 888ee0a into master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants