Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move missing EOL fixtures to another file #178

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Move missing EOL fixtures to another file #178

merged 6 commits into from
Oct 24, 2023

Conversation

abdullah-kasim
Copy link
Contributor

@abdullah-kasim abdullah-kasim commented Oct 23, 2023 •
edited
Loading

Description

As per the title says, I'm moving the missing EOL fixture to another file so that the javascript.js fixture is a lot easier to modify.

@abdullah-kasim abdullah-kasim requested a review from a team October 23, 2023 02:57
@abdullah-kasim abdullah-kasim force-pushed the update/move-no-eol-fixture-to-another-file branch from b893147 to e1ce6d0 Compare October 23, 2023 03:03
@abdullah-kasim
Copy link
Contributor Author

abdullah-kasim commented Oct 23, 2023 •
edited
Loading

Interestingly, eol-last is actually overridden by prettier's eslint rules, so you don't see eol-last in the Jest snapshot.

chriszarate
chriszarate approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@chriszarate chriszarate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Interestingly, eol-last is actually overridden by prettier's eslint rules, so you don't see eol-last in the Jest snapshot.

I don't mind the redundancy in case Prettier changes its approach in the future

@abdullah-kasim
Copy link
Contributor Author

I don't mind the redundancy in case Prettier changes its approach in the future

Yup me neither :)

@abdullah-kasim abdullah-kasim merged commit 501f84f into trunk Oct 24, 2023
4 checks passed
@abdullah-kasim abdullah-kasim deleted the update/move-no-eol-fixture-to-another-file branch October 24, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriszarate chriszarate chriszarate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdullah-kasim @chriszarate