-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly remember last url when multiple blocks are on the same page #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ashfame
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Merged
@psrpinto researched using Gutenberg's own client ID (UUID for blocks) but the problem with that is that it changes between saves, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple blocks are on the same page, in different screens (e.g. different rooms), refreshing the page would not correctly bring each block to the screen where they were previously on.
This PR fixes that by introducing an
instanceId
attribute which is unique for each block on a page. We then use thatinstanceId
to namespace thechatrix_last_url_hash
property in local storage, so that it becomeschatrix_abc123_last_url_hash
(whereabc123
is theinstanceId
).Note: For blocks created before this PR, the pages will need to be re-saved for the block(s) to get an
instanceId
.Screen recording
Screen.Recording.2023-04-17.at.16.34.20.mov