Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single room mode with room alias #179

Merged
merged 13 commits into from
Feb 8, 2023
Merged

Single room mode with room alias #179

merged 13 commits into from
Feb 8, 2023

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Feb 2, 2023

Fixes #172

This PR makes it possible to enter either a room alias or a room id in the block inspector, or in the popup settings.

Screenshot 2023-02-02 at 17 44 22

@psrpinto psrpinto self-assigned this Feb 2, 2023
@psrpinto psrpinto marked this pull request as ready for review February 2, 2023 16:44
@psrpinto psrpinto marked this pull request as draft February 2, 2023 17:14
@psrpinto
Copy link
Member Author

psrpinto commented Feb 2, 2023

Putting this back on draft to properly address the case where resolving the room alias fails.

@psrpinto
Copy link
Member Author

psrpinto commented Feb 3, 2023

Case where alias resolution fails has now been addressed, ready for review.

@psrpinto psrpinto marked this pull request as ready for review February 3, 2023 13:56
Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@psrpinto psrpinto merged commit b8cce82 into main Feb 8, 2023
@psrpinto psrpinto deleted the room-alias branch February 8, 2023 16:38
@ashfame ashfame mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for using room alias for single-room mode
2 participants