Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve single room mode #151

Merged
merged 14 commits into from
Jan 5, 2023
Merged

Improve single room mode #151

merged 14 commits into from
Jan 5, 2023

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Dec 21, 2022 •
edited
Loading

Fixes #91

This PR fixes the following issues with single-room mode:

  1. In single-room mode, user cannot access the settings #91
  2. In non-small screens, single-room mode was not functional, since user still had access to list of rooms.
  3. User could not access session picker when in single-room mode.

This PR implements the following changes, which fix all above issues.

When in single room mode:

  1. Hide the left panel completely
  2. Add a Settings entry to the options menu of the room
  3. Closing the Settings screen navigates to configured roomId
  4. Closing the Room (timeline) screen navigates to session picker

Screen captures

Small screen

Screen.Recording.2022-12-22.at.17.09.15.mov

Non-small screen

Screen.Recording.2022-12-22.at.17.23.02.mov

@psrpinto psrpinto changed the base branch from main to delete-sessions December 21, 2022 16:56
@psrpinto psrpinto self-assigned this Dec 22, 2022
@psrpinto psrpinto marked this pull request as ready for review December 22, 2022 17:33
ashfame
ashfame approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from delete-sessions to main January 5, 2023 13:25
@psrpinto psrpinto merged commit 3a951bd into main Jan 5, 2023
@psrpinto psrpinto deleted the single-room-mode-settings branch January 5, 2023 13:26
@psrpinto psrpinto mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfame ashfame ashfame approved these changes

@akirk akirk Awaiting requested review from akirk

Assignees

@psrpinto psrpinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In single-room mode, user cannot access the settings
2 participants
@psrpinto @ashfame