Example rspec tests
#64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Base automatically changed from
mokagio/omit-details-annotation-when-empty
to
trunk
June 8, 2023 10:54
mokagio
force-pushed
the
mokagio/add-some-tests
branch
from
96ba48c to
6e8e9ee
Compare
mokagio
commented
Jun 8, 2023
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| gem "rexml" |
There was a problem hiding this comment.
We'd probably want to use nokogiri if we pushed this to "production" as it's the more commonly used, but this does the job alright in this context.
mokagio
commented
Jun 8, 2023
| @@ -1,14 +1,17 @@ | |||
| .DEFAULT_GOAL := default | |||
|
|
|||
| lint: buildkite-plugin-lint rubocop shellcheck | |||
| test: buildkite-plugin-test buildkite-plugin-test-commands-are-executable | |||
| test: unit-tests buildkite-plugin-test buildkite-plugin-test-commands-are-executable | |||
|
|
|||
| buildkite-plugin-test: | |||
| docker run -t --rm -v "${PWD}":/plugin buildkite/plugin-tester | |||
|
|
|||
| buildkite-plugin-test-commands-are-executable: | |||
| docker run -t --rm -v "${PWD}":/plugin -w /plugin ruby:2.7.4 /bin/bash -c "gem install --silent rspec && rspec tests/test-that-all-files-are-executable.rb" | |||
There was a problem hiding this comment.
I didn't change this Ruby value to the one from the new .ruby-version to keep this PR focused.
mokagio
commented
Jun 8, 2023
| @@ -0,0 +1 @@ | |||
| 3.2.2 | |||
There was a problem hiding this comment.
Given this is an experiment, might as well try with the latest Ruby :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.