Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.6.2 #119

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Release/3.6.2 #119

merged 3 commits into from
Sep 13, 2024

Conversation

wzieba
Copy link
Member

@wzieba wzieba commented Sep 13, 2024


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@wzieba wzieba requested a review from AliSoftware September 13, 2024 08:38
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all good with doing another release, but wanted to ask first: given the small glitches we missed here and there with the sarif helper, did you test the latest fix in a client project before release, by making that project point to a8c-ci-toolkit#trunk (or a8c-ci-toolkit#{commitsha}) then create test branches and PRs to validate it works? That way we can find potential other issues before doing a new release instead of having to do a 3.6.3 in case we find out we missed another silly thing in 3.6.2 🙃

@wzieba
Copy link
Member Author

wzieba commented Sep 13, 2024

Usually, I do this, but the thing to test here is about uploading a sarif fail on a main branch. So I'd have to merge a8c-ci-toolkit#trunk to main branch of a project, which is something I wanted to omit :/ .

@AliSoftware
Copy link
Contributor

So I'd have to merge a8c-ci-toolkit#trunk to main branch of a project, which is something I wanted to omit :/ .

Ah, got it! Makes sense 👍

@wzieba
Copy link
Member Author

wzieba commented Sep 13, 2024

On the second thought, let's test this because I'm quite weary of releasing the toolkit 😅

@wzieba
Copy link
Member Author

wzieba commented Sep 13, 2024

Worked as expected 🎉 https://github.com/Automattic/pocket-casts-android/security/code-scanning

@wzieba wzieba merged commit 643381d into trunk Sep 13, 2024
13 checks passed
@wzieba wzieba deleted the release/3.6.2 branch September 13, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants