-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Setup Dangermattic #113
Conversation
b9bef16
to
640b7b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rules applied here looks good to me and appropriate to how we use this repo 👍
.buildkite/pipeline.yml
Outdated
command: make test | ||
agents: | ||
queue: default | ||
|
||
- label: "☢️ Danger - PR Check" | ||
- label: ":radioactive_sign: Danger - PR Check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a change in steps labels will require updating the branch protection settings on GitHub with the new derived names for the required checks.
Given the long names Buildkite already ends up generating on the existing GitHub checks (e.g. buildkite/ci-toolkit-buildkite-plugin/swift-standalone-swift-package-autodetect
) and how using :emoji:
codes like here will also lead to long labels (like buildkite/ci-toolkit-buildkite-plugin/radioactive-sign-danger-pr-check
)… I think this could be a good occasion to use this repo as guinea pig for paaHJt-78h-p2, as we could consider:
- Turning off the
publish_commit_status
setting on the pipeline (the one that makes Buildkite generate status based on label names) - Instead declare
notify
attributes (with e.g.{github_commit_status: { context: "Danger - PR Check" } }
) explicitly for every single step in thepipeline.yml
PS: Given all of this, you might want to revert this commit from the time being and instead apply those changes in a separate PR instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up @iangmaia . Love having automation working to help me remember things.
05d0822
to
23e13f7
Compare
This reverts commit 8a3b874.
This PR adds Danger / Dangermattic to the project: the Buildkite pipeline as well as the Github Action workflow to trigger it based on events such as on label / reviewers updates.
CHANGELOG.md
if necessary.