Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Setup Dangermattic #113

Merged
merged 8 commits into from
Sep 10, 2024
Merged

[Tooling] Setup Dangermattic #113

merged 8 commits into from
Sep 10, 2024

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Sep 9, 2024

This PR adds Danger / Dangermattic to the project: the Buildkite pipeline as well as the Github Action workflow to trigger it based on events such as on label / reviewers updates.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia self-assigned this Sep 9, 2024
@iangmaia iangmaia marked this pull request as ready for review September 9, 2024 18:33
@iangmaia iangmaia force-pushed the iangmaia/setup-danger branch from b9bef16 to 640b7b0 Compare September 9, 2024 18:37
@iangmaia iangmaia requested a review from a team September 9, 2024 18:38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rules applied here looks good to me and appropriate to how we use this repo 👍

@iangmaia iangmaia enabled auto-merge (squash) September 9, 2024 19:15
command: make test
agents:
queue: default

- label: "☢️ Danger - PR Check"
- label: ":radioactive_sign: Danger - PR Check"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a change in steps labels will require updating the branch protection settings on GitHub with the new derived names for the required checks.

Given the long names Buildkite already ends up generating on the existing GitHub checks (e.g. buildkite/ci-toolkit-buildkite-plugin/swift-standalone-swift-package-autodetect) and how using :emoji: codes like here will also lead to long labels (like buildkite/ci-toolkit-buildkite-plugin/radioactive-sign-danger-pr-check)… I think this could be a good occasion to use this repo as guinea pig for paaHJt-78h-p2, as we could consider:

  • Turning off the publish_commit_status setting on the pipeline (the one that makes Buildkite generate status based on label names)
  • Instead declare notify attributes (with e.g. {github_commit_status: { context: "Danger - PR Check" } }) explicitly for every single step in the pipeline.yml

PS: Given all of this, you might want to revert this commit from the time being and instead apply those changes in a separate PR instead.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up @iangmaia . Love having automation working to help me remember things.

Dangerfile Outdated Show resolved Hide resolved
@iangmaia iangmaia force-pushed the iangmaia/setup-danger branch from 05d0822 to 23e13f7 Compare September 10, 2024 17:11
@iangmaia iangmaia disabled auto-merge September 10, 2024 17:11
@iangmaia iangmaia enabled auto-merge (squash) September 10, 2024 17:14
@iangmaia iangmaia merged commit 4c31530 into trunk Sep 10, 2024
13 of 14 checks passed
@iangmaia iangmaia deleted the iangmaia/setup-danger branch September 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants