Add PowerShell command to setup Windows environment #100

mokagio · 2024-06-03T03:33:47Z

I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

AliSoftware · 2024-06-04T11:14:07Z

Makefile

-	$(docker_run) koalaman/shellcheck hooks/** bin/** --exclude=SC1071
+	$(docker_run) koalaman/shellcheck $(shell find hooks bin -type f -not -name "*.ps1") --exclude=SC1071


👍

(I wonder if there's a shellcheck equivalent for PowerShell btw… though probably only a thing to look at when we'll start tacking #101 more officially/broadly?)

I wonder if there's a shellcheck equivalent for PowerShell btw…

Found this… in case we want to look into it at some point

AliSoftware · 2024-06-04T11:14:21Z

tests/test-that-all-files-are-executable.rb

-context 'All Commands Should Be Executable' do
-  Dir.children('bin').map { |f| File.new(File.join('bin', f)) }.each do |file|
-    it file.path do
-      expect(file.stat.executable?).to be true
+context 'All Unix Commands Should Be Executable' do
+  Dir
+    .children('bin')
+    # Ignore Windows PowerShell scripts
+    .reject { |f| f.end_with?('.ps1') }


* Introduce `merge_junit` script To improve performance of Android unit tests collection. Originated it woocommerce/woocommerce-android#12064 * Add changelog entry * Address SC2129 Consider using { cmd1; cmd2; } >> file instead of individual redirects. https://www.shellcheck.net/wiki/SC2129 * Remove `sh` suffix To align to other commands * Create output file before saving data there * Rename script to `merge_junit_reports` * Remove `<testsuites>` tag if it's present in any report that is about to be merged * Update CHANGELOG.md Co-authored-by: Olivier Halligon <[email protected]> --------- Co-authored-by: Olivier Halligon <[email protected]>

* Link to GitHub releases instead of updating README on each release To streamline the process * Update CHANGELOG.md * Remove typo in README * Revert "Remove typo in README" This reverts commit 09a36fd. * Revert "Link to GitHub releases instead of updating README on each release" This reverts commit 5e51cf7. * Update version in README to 3.5.0

… name (#106) By moving away from using an XPath expression and instead doing the filtering manually on the array of all the testcase sibling nodes

If a project uses `yarn` it should not use the `npm ci` command in CI!

See #96 (comment) Co-authored-by: Olivier Halligon <[email protected]>

Even if one runs `chmod u+x` on the file, the test fails. Anyways, we don't care about PowerShell being executable from a Unix point of view, because they should be used only under Windows.

I usually use Vim for Ruby files, where I have RuboCop configured. Today, I used VS Code, where I _should have_ configured RuboCop but evidently have not.

Context: I tried calling `add_ssh_key_to_agent` straight from the Windows environment but it didn't work.

`LocalMachine` might not be allowed at a access right level. See how this build failed https://buildkite.com/automattic/beeper-desktop/builds/2897#0191979b-a067-4780-8a45-f051515841f1

Doesn't work! ChatGPT what are you suggesting?! https://buildkite.com/automattic/beeper-desktop/builds/2901#019197e0-da5d-47ec-84ec-8327b4aa5c7c/273-279

Seems like all the flags did not make any difference in terms of whether the symlink creation was attempted. E.g. This build failed with the same symlink error as before, despite having the flags https://buildkite.com/automattic/beeper-desktop/builds/2907#0191982e-d1c5-402f-99be-2299321ccbe6

mokagio force-pushed the mokagio/npm_ci branch from c4cda93 to 154bde2 Compare June 3, 2024 03:35

mokagio force-pushed the mokagio/windows-utils branch from 92062e0 to 6f010f1 Compare June 3, 2024 03:36

mokagio mentioned this pull request Jun 3, 2024

Add alternative command to run npm ci with cache #96

Draft

1 task

AliSoftware approved these changes Jun 4, 2024

View reviewed changes

wzieba and others added 16 commits August 5, 2024 17:19

Avoid issues with test cases having apostrophes in their classname or…

6215139

… name (#106) By moving away from using an XPath expression and instead doing the filtering manually on the array of all the testcase sibling nodes

Prepare for release 3.5.1 (#107)

44289fe

Remove a trailing whitespace

79e05e2

Tweak error messages in install_npm_packages

6300f47

Add command to run npm ci

2eef52e

Remove note about yarn from npm ci command

b41286c

If a project uses `yarn` it should not use the `npm ci` command in CI!

Add documentation for patches support to npm ci command

0baaf8d

See #96 (comment) Co-authored-by: Olivier Halligon <[email protected]>

Add script to set up Windows host for Node development

c751008

Ignore PowerShell scripts in test for executable property

bd4f26b

Even if one runs `chmod u+x` on the file, the test fails. Anyways, we don't care about PowerShell being executable from a Unix point of view, because they should be used only under Windows.

Address RuboCop violation

a0e6ea6

I usually use Vim for Ruby files, where I have RuboCop configured. Today, I used VS Code, where I _should have_ configured RuboCop but evidently have not.

Update ShellCheck command to exclude PowerShell files

cb76156

Log more information in hooks/environment

e753c71

Context: I tried calling `add_ssh_key_to_agent` straight from the Windows environment but it didn't work.

Print CI header upon running add_ssh_key_to_agent

59ade00

Make hooks/environment properly set PATH in Windows

e36edc3

mokagio force-pushed the mokagio/windows-utils branch from 2c0b1d1 to e36edc3 Compare August 28, 2024 02:59

mokagio added 9 commits August 28, 2024 13:29

Remove OS-specific handling of paths in hooks/environment

ad66cd5

Add debug PATH print statement in Windows PS1

618e060

Fix typo

fe9dab2

Add $PATH retaining workaround to refreshenv call

9fae08c

Try to set dev mode for Windows machines

c0d2bee

Use CurrentUser instead of LocalMachine

37f3dbb

`LocalMachine` might not be allowed at a access right level. See how this build failed https://buildkite.com/automattic/beeper-desktop/builds/2897#0191979b-a067-4780-8a45-f051515841f1

Try different approach for developer mode

ad3c11d

Debug print user roles in Windows

e7c1ff5

Implement conditional behavior for tar in Windows

2ca9271

mokagio added 2 commits August 28, 2024 17:41

Remove --no-symlinks

0edae80

Doesn't work! ChatGPT what are you suggesting?! https://buildkite.com/automattic/beeper-desktop/builds/2901#019197e0-da5d-47ec-84ec-8327b4aa5c7c/273-279

mokagio mentioned this pull request Nov 4, 2024

Move script to install Windows 10 SDK to CI toolkit #132

Open

mokagio added 4 commits November 12, 2024 11:14

Run nvm setup at the end of the prepare Win host script

bbc7a30

If now .nvmrc found, skip Node set up

d2ce959

Fix early exit check for .nvmrc in Windows

848f33e

Do not open roles group

22c57b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PowerShell command to setup Windows environment #100

Add PowerShell command to setup Windows environment #100

mokagio commented Jun 3, 2024

AliSoftware Jun 4, 2024

AliSoftware Jun 25, 2024 •

edited

Loading

AliSoftware Jun 4, 2024

		$(docker_run) koalaman/shellcheck hooks/ bin/ --exclude=SC1071
		$(docker_run) koalaman/shellcheck $(shell find hooks bin -type f -not -name "*.ps1") --exclude=SC1071

Add PowerShell command to setup Windows environment #100

Are you sure you want to change the base?

Add PowerShell command to setup Windows environment #100

Conversation

mokagio commented Jun 3, 2024

AliSoftware Jun 4, 2024

Choose a reason for hiding this comment

AliSoftware Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

AliSoftware Jun 4, 2024

Choose a reason for hiding this comment

AliSoftware Jun 25, 2024 •

edited

Loading