Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor-style #225

Closed
wants to merge 1 commit into from
Closed

Add editor-style #225

wants to merge 1 commit into from

Conversation

RistoNiinemets
Copy link

Why not "reset" editor-style also?

@jackmahoney
Copy link

Cool. On a similar note can we consider adding the 'fontselect' and 'fontsize' aspects to the tinymce using the standard filters.

For instance

//add tinymce buttons
function my_mce_buttons_2( $buttons ) {
    array_unshift( $buttons, 'fontselect' );
    array_unshift( $buttons, 'fontsizeselect' );
    return $buttons;
}
add_filter('mce_buttons_2', 'my_mce_buttons_2');

I feel like these should really be turned on by default.

@sabreuse
Copy link
Contributor

re: buttons, please no -- if you want to argue for them being available by default, then core Trac is the place for the argument. But it's really not the kind of setting that should be determined by a theme.

@jackmahoney
Copy link

Core is too messy to accept a change like that in my opinion. I do agree with you in a sense but I think that _s strives to make a clean experience for the user. Most theme author's would neglect this feature, but adding it would improve the end user's experience

@RistoNiinemets
Copy link
Author

There are multiple buttons that are available, but not used in WordPress core. For example, I usually have the need for Horizontal Rule. I do not see the need for font changing, as using different fonts on the same page is rather a design issue.

Of course, the need for different things is huge and we can not just select just two buttons. Therefore, I do not think this is necessary.

@whatsnewsisyphus
Copy link

Letting the user select the font will disrupt most designs, the editor of the theme can easily add it for the specific site that they wish to use it in, most sites do not need it.

@michiecat
Copy link
Contributor

We decided that this is not necessary. As a starter theme, _s doesn't have any styles to begin with. Theme developers can add editor styles as needed on a per-theme basis.

@ianstewart ianstewart closed this Jul 3, 2013
@philiparthurmoore
Copy link
Collaborator

As a starter theme, _s doesn't have any styles to begin with.

This isn't entirely accurate. :)

Probably still a good idea to keep this closed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants