Repair edit job listing screen.

[gikaragia]

Oveview

This fixes an issue to the edit job listing screen. To reproduce:

1. Create a job and publish it
2. Set up a recaptcha and enable it in the settings (any version will do, go to https://www.google.com/recaptcha to create keys if you don't have some already)
3. Go to the job dashboard
4. Edit the job
5. After doing some change try to save the listing
6. At this point the update fails and nothing happens

The problem was that we added the actions to the WP_Job_Manager_Recaptcha constructor. This way the hooks were added even when we wanted to call utility methods and the captcha was also enqueued to the dashboard page.

Changes Proposed in this Pull Request

• I moved the hook registration from the constructor to equeue_scripts. This way we only enqueue the captcha when we need to.

Testing Instructions

• Test together with: https://github.com/Automattic/wpjm-addons/pull/481
• Follow the steps from the overview and observe that nothing is broken now.
• Also try testing recaptcha functionality in general to ensure that nothing else is broken.
• Additionally, we should test how the changes in reCAPTCHA work in relation to different plugin versions:
  • The newest version of the paid plugins should work with the previous version of WPJM (i.e. 2.2.2) but with v2 reCAPTCHA only
  • The previous versions of the paid plugins should work with latest version of WPJM but with warnings printed as we deprecated the old methods.

---

Plugin build for 42aae9c
📦 Download plugin zip
▶️ Open in playground

[yscik]

Haven't tested yet, but it looks fragile to add the hooks that process submit fields in the output and enqueue functions. Those might not get called or get called later than process(). Does it only work now because the submit job form has multiple steps?

Since reCAPTCHA is only used on specific forms I think the abstract WP_Job_Manager_Form class, which has the common code for every form, isn't the place to set it up. Looks like there are separate WP_Job_Manager_Form_Edit_Job and WP_Job_Manager_Form_Submit_Job classes, should the hooks be added from here?:

WP-Job-Manager/includes/forms/class-wp-job-manager-form-submit-job.php

Line 83 in 881c4f3

WP_Job_Manager\WP_Job_Manager_Recaptcha::instance();

(Unfortunately WP_Job_Manager_Form_Edit_Job extends WP_Job_Manager_Form_Submit_Job so we still need something to not load it for editing. Maybe a ...Submit_Job::init_recaptcha() method that the ...Edit_Job class overrides?)

[gikaragia]

Great point, I also thought about this initially but I ended up taking the quick approach since it worked. I'll look into refactoring

[gikaragia]

Ok so I moved everything inside the recaptcha class. I also did some fixes regarding versioning as it seems that previously the latest version of the paid plugins didn't work with old WPJM versions. I have updated the testing instructions to reflect that.

[yscik]

Looks good!