Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primary action to job dashboard and overlay #2800

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Add primary action to job dashboard and overlay #2800

merged 3 commits into from
Apr 15, 2024

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Apr 4, 2024 •
edited by github-actions bot
Loading

Fixes #2747

Changes Proposed in this Pull Request

  • In the job dashboard, add a button for the most relevant action to each row
  • Same in the job overlay footer
  • Fix action links in the overlay
  • Improve mobile overlay styling

Testing Instructions

  • Build frontend with npm run start
  • Open up the job dashboard and check that jobs have a button with the primary action
  • Check that the actions are working as expected

Screenshot / Video

image
Plugin build for 14f70e2
📦 Download plugin zip
▶️ Open in playground

@yscik yscik requested a review from a team April 4, 2024 15:03
@yscik yscik self-assigned this Apr 4, 2024
@yscik yscik linked an issue Apr 4, 2024 that may be closed by this pull request
Determine and show primary action in jobs dashboard #2747
Closed
@yscik yscik requested a review from gikaragia April 11, 2024 14:59
gikaragia
gikaragia approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yscik yscik merged commit 4175f4f into feature/stats Apr 15, 2024
11 checks passed
@yscik yscik deleted the add/job-dashboard-primary-action branch April 15, 2024 12:00
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@yscik yscik added this to the 2.3.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Determine and show primary action in jobs dashboard
2 participants
@yscik @gikaragia