-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stats section to job overlay #2776
Conversation
1b26da5
to
ea8314b
Compare
67c2b07
to
4934242
Compare
4934242
to
0446d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
When opening the modal, the ajax fails, because I have a warning "Warning: Undefined array key "posts_per_page" in /var/www/html/wp-content/plugins/WP-Job-Manager/includes/class-job-dashboard-shortcode.php on line 636", it seems to come from this PR, there's no default set for posts_per_page and $args['posts_per_page'] is checked in the method.
Also had a bunch of other warnings once this one was fixed 😅 :
I could only get some stats after running the wp command, but that's maybe normal ?
Last (but not least), something's happening there and the pages hangs the Firefox tab for a while, after the modal is displayed:
I suspect that's to do with the 100 years of stats it's supposed to render :D I'll put some sane limit on it. |
Fixes #2744, fixes #2745, fixes #2746
Changes Proposed in this Pull Request
Testing Instructions
wp jm dev stats generate <postId>
New or Updated Hooks and Templates
job_manager_job_stats_chart
- Filter the data for the daily breakdown chartjob_manager_job_stats_summary
- Filter the sections and data for the summariesjob_manager_ui_accent_color
- Set an accent color manuallyScreenshot / Video