Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce stat for jobs impressions. #2771

Merged
merged 21 commits into from
Feb 28, 2024
Merged

Introduce stat for jobs impressions. #2771

merged 21 commits into from
Feb 28, 2024

Conversation

pgk
Copy link
Contributor

@pgk pgk commented Feb 19, 2024 •
edited by github-actions bot
Loading

Fixes #2751

Changes Proposed in this Pull Request

  • Introduce listing impressions on job search.
  • Refactors the declarative php and the frontend js side.
  • Refactors stats ajax endpoint to accept more/multiple data.

Testing Instructions

  • Open a page that contains the [jobs] shortcode.
  • check that on page load, the first 10 listings are logged as impressions.
  • Press load more
  • Check that impressons are queued up and ajax calls are periodically done as you scroll.

Release Notes

New or Updated Hooks and Templates

Deprecated Code

Screenshot / Video

Plugin build for 868bd05
📦 Download plugin zip
▶️ Open in playground

yscik
yscik reviewed Feb 19, 2024
View reviewed changes
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
includes/class-stats.php Outdated Show resolved Hide resolved
templates/content-job_listing.php Outdated Show resolved Hide resolved
includes/class-stats.php Show resolved Hide resolved
includes/class-stats.php Show resolved Hide resolved
@pgk pgk force-pushed the add/stat-listing-search-impressions branch from 958800a to 74d7711 Compare February 20, 2024 12:08
Base automatically changed from add/stat-listing-apply-clicked to feature/stats February 20, 2024 12:20
@pgk pgk self-assigned this Feb 20, 2024
@pgk pgk requested a review from a team February 21, 2024 11:41
pgk
pgk commented Feb 21, 2024
View reviewed changes
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
yscik
yscik reviewed Feb 22, 2024
View reviewed changes
includes/class-stats.php Outdated Show resolved Hide resolved
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
assets/js/wpjm-stats.js Outdated Show resolved Hide resolved
assets/js/stats/utils.js Outdated Show resolved Hide resolved
assets/js/stats/unique.js Outdated Show resolved Hide resolved
assets/js/stats/unique.js Outdated Show resolved Hide resolved
@pgk pgk force-pushed the add/stat-listing-search-impressions branch from acdaa99 to 4303b77 Compare February 22, 2024 16:32
@pgk pgk requested a review from yscik February 23, 2024 14:20
@pgk pgk requested a review from a team February 23, 2024 14:21
@yscik yscik mentioned this pull request Feb 28, 2024
Closed
yscik
yscik approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work on this one! I saw a small issue of some listings being skipped occasionally, adding it to a new card here along with the various optimization things that came up.

@yscik yscik merged commit 5803e83 into feature/stats Feb 28, 2024
11 checks passed
@yscik yscik deleted the add/stat-listing-search-impressions branch February 28, 2024 11:40
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Closed
@yscik yscik added this to the 2.3.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yscik yscik yscik approved these changes

Assignees

@pgk pgk

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pgk @yscik