Add Webpack/Eslinting for Gutenberg blocks #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbtlr
changed the title
alexsanford
reviewed
Jun 27, 2018
.eslintrc.js
Outdated
| globals: { | ||
| wp: true, | ||
| window: true, | ||
| document: true, |
There was a problem hiding this comment.
Funky indentation here
| /** | ||
| * Register all Gutenblocks | ||
| */ | ||
| public function register_blocks() { |
There was a problem hiding this comment.
This is likely to fail since the jobs block is gone. Should we just stub this function out?
|
WordPress' Babel preset package will handle Babel config: https://github.com/WordPress/packages/tree/master/packages/babel-preset-default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #1521
This PR adds in all of the webpack building and eslinting required to build a Gutenberg block.
The Build
The build is pretty standard webpack/babel, with some things borrowed from the Gutenberg build.
I've included it in our
grunt-based existing build system.When we start building the other blocks, there are a few things we may need to consider: