Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ef_custom_status_list filter on get_custom_statuses() #587

Merged
merged 4 commits into from
Jan 29, 2020

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jan 27, 2020

Description

This fixes #586, where filtering custom statuses by user role wasn't working.

Steps to Test

  1. Check out PR.
  2. Limit user role to subset of custom statuses as described here
  3. Click the custom status drop-down while editing/creating a post as that user role, and see which custom statuses you have access to

@cojennin
Copy link
Contributor

Ah yea, good spot @jsit. Can you apply the filter here instead?

That makes it consistent with it's other usage.

You probably put the change where we'll want to put it eventually, but I'd like some more testing around it before we make it permanent. It'll be less impactful to put it here and then hopefully we can get it out with the next release in a few days (fingers crossed)

@jsit
Copy link
Contributor Author

jsit commented Jan 27, 2020

Thanks @cojennin; do the changes I've just committed make sense?

@WPprodigy
Copy link
Contributor

You probably put the change where we'll want to put it eventually, but I'd like some more testing around it before we make it permanent.

I agree. And on a quick look, I can see a few potential pit falls to putting it there without testing. It definitely should have been there from the start though 😣

do the changes I've just committed make sense?

Looks good @jsit ! Just tested and works as expected.

@jsit jsit requested a review from WPprodigy January 28, 2020 03:32
@cojennin cojennin merged commit 8def9ee into Automattic:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ef_custom_status_list filter doesn't seem to be working
3 participants