Ensure status_friendly_names are provided for notifications #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2019
mjangda
reviewed
Dec 13, 2019
Co-Authored-By: Mohammad Jangda <[email protected]>
Co-Authored-By: Mohammad Jangda <[email protected]>
Co-Authored-By: Mohammad Jangda <[email protected]>
Co-Authored-By: Mohammad Jangda <[email protected]>
Co-Authored-By: Mohammad Jangda <[email protected]>
mjangda
reviewed
Dec 18, 2019
Not related to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra work on top of @jerclarke's work in #502 to add tests and account for cases where a
status_objwould be null.