Prepare v3.2.2 release

[philipjohn]

Full changeset for this release: 69f58e2...bd13386

[mjangda]

Main issue I spotted is #367 (comment) -- other than that, I think we're looking good.

[mjangda]

Actually, need to look at the test failures too:

There were 2 failures:
1) Test_Author_Queried_Object::test__author_queried_object_fix
is_archive, is_author is expected to be true. is_404 is expected to be false.
Failed asserting that false is true.
/tmp/wordpress-tests-lib/includes/testcase.php:609
/home/travis/build/Automattic/Co-Authors-Plus/tests/test-author-queried-object.php:73

2) Test_Manage_CoAuthors::test_add_coauthor_to_post
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 9
-    1 => 10
 )

[philipjohn]

#406 addresses the various other instances of get_the_terms()

1. Test_Author_Queried_Object::test__author_queried_object_fix

Looks like this broke with [6dbcd3c], see 425.9

2. Test_Manage_CoAuthors::test_add_coauthor_to_post

This one broke with [52da0aa], see 433.9

The latter is fixed by [d5305b5].

[mjangda]

Test_Author_Queried_Object::test__author_queried_object_fix
Looks like this broke with [6dbcd3c], see 425.9

@sboisvert @trepmal can you please take a look? ^^

[trepmal]

The temporary tables are due to the way WordPress gets installed on the fly for testing.

https://core.trac.wordpress.org/browser/trunk/tests/phpunit/includes/testcase.php#L312 - summarized:

add_filter( 'query', function( $query ) {
	if ( 'CREATE TABLE' === substr( trim( $query ), 0, 12 ) ) {
		return substr_replace( trim( $query ), 'CREATE TEMPORARY TABLE', 0, 12 );
	}
	return $query;
} );

Interestingly (or not), we're only encountering this because we test in multisite. The initial tables that are installed are not temporary, but the subsite tables are (since those pass through the query filter).

If I simply comment out those filters and rerun the tests, they pass.

— #398 (comment)

[trepmal]

I kinda missed the intro in my reply... but #398 provides the context