UI: Add capability check to Add New button #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background: - Take a role like Subscriber which only has `read` capability. - Adding `list_users` to an account with a Subscriber role allows the Users admin menu to appear, and the Guest Authors list page to be accessed. - However, clicking on the Add New button won't work, as they haven't got permission to edit this post type. - Allowing `edit_posts` capability allows the Add New screen to be accessed; currently the `list_authors` capability is used on the handling of the guest author creation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
readcapability.list_usersto an account with a Subscriber role allows the Users admin menu to appear, and the Guest Authors list page to be accessed.edit_postscapability allows the Add New screen to be accessed; currently thelist_authorscapability is used on the handling of the guest author creation.Fixes #1001.
Before
Button visible, but clicking through leads to a cap check failure.
After
Button not visible. Trying to accessing the page directly through URL manipulation will still give the cap check failure.