Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CocoaPods 1.0 #49

Merged
merged 11 commits into from
May 11, 2016
Merged

Update to CocoaPods 1.0 #49

merged 11 commits into from
May 11, 2016

Conversation

astralbodies
Copy link
Contributor

@astralbodies astralbodies commented May 10, 2016

Closes #48

Modernize the project to use Frameworks everywhere, fix CocoaLumberjack issues, and use CocoaPods 1.0 (rc2 at the moment).

Testing:

  1. Install CocoaPods 1.0.0.rc.2 and install pods in the main project and TracksDemo.
  2. Build each project.
  3. Run TracksDemo.

@kwonye kwonye self-assigned this May 10, 2016
@kwonye
Copy link
Contributor

kwonye commented May 10, 2016

@astralbodies are the cocoalumberjack macro warnings ok?

@astralbodies
Copy link
Contributor Author

@kwonye I can set the Podfile to ignore them - but yeah I think they're okay for now

@kwonye
Copy link
Contributor

kwonye commented May 10, 2016

Slightly unrelated, but I can't seem to run tests through Xcode. Can we fix that on this PR please?

Edit: Seems like Travis can't run tests either so maybe it is related to this PR after all

@astralbodies
Copy link
Contributor Author

@kwonye I think I've solved it. I had to add a Swift file to the main project to force the bundling of a module map. I also tweaked the Podfile to nest the test target into the main target. Feels weird but I get why it had to be done.

@kwonye
Copy link
Contributor

kwonye commented May 10, 2016

👍 everything works for me locally and travis builds fine so :shipit:

@astralbodies
Copy link
Contributor Author

astralbodies commented May 11, 2016

@jleandroperez Can you give the Mac OS X podspec a whirl with 0.1.0 and CocoaPods 1.0 w/Simplenote?

@astralbodies astralbodies merged commit b360926 into develop May 11, 2016
@astralbodies astralbodies deleted the issue/48-cocoapods-1.0 branch May 11, 2016 00:41
@jleandroperez
Copy link
Contributor

Building great! Simlpenote OSX PR Here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to CocoaPods 1.0
3 participants