-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CocoaPods 1.0 #49
Conversation
@astralbodies are the cocoalumberjack macro warnings ok? |
@kwonye I can set the Podfile to ignore them - but yeah I think they're okay for now |
Slightly unrelated, but I can't seem to run tests through Xcode. Can we fix that on this PR please? Edit: Seems like Travis can't run tests either so maybe it is related to this PR after all |
@kwonye I think I've solved it. I had to add a Swift file to the main project to force the bundling of a module map. I also tweaked the Podfile to nest the test target into the main target. Feels weird but I get why it had to be done. |
👍 everything works for me locally and travis builds fine so |
@jleandroperez Can you give the Mac OS X podspec a whirl with 0.1.0 and CocoaPods 1.0 w/Simplenote? |
Building great! Simlpenote OSX PR Here |
Closes #48
Modernize the project to use Frameworks everywhere, fix CocoaLumberjack issues, and use CocoaPods 1.0 (rc2 at the moment).
Testing: