Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releaseName default value #267

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Update releaseName default value #267

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7e4de90
Make `releaseName` optional and remove default value
spencertransier Nov 10, 2023
2c943c8
Don't default to nil
spencertransier Nov 10, 2023
83ec687
Default to an empty string
spencertransier Nov 10, 2023
56d7372
Default to nil
spencertransier Nov 10, 2023
07c5385
Set explicit value for release name
spencertransier Nov 11, 2023
efc54eb
Fix constant name
spencertransier Nov 11, 2023
d3bbdba
Remove unneeded comment
spencertransier Nov 11, 2023
6c0f7a2
Add version numbers to the demo project
spencertransier Nov 11, 2023
50375ae
Update CHANGELOG.md
spencertransier Nov 11, 2023
d109b5c
Remove demo version numbers
spencertransier Nov 14, 2023
9587642
Revert xcodeproj change
spencertransier Nov 14, 2023
9ed685c
Test removing releaseName
spencertransier Nov 14, 2023
122cf96
Remove releaseName from the protocol
spencertransier Nov 14, 2023
b9de733
Update the CHANGELOG from internal change to breaking change
spencertransier Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ _None._

### Internal Changes

_None._
- The default `releaseName` value now includes the CFBundleIdentifierKey, CFBundleShortVersionString, and CFBundleVersionKey [#267]

-->

Expand Down
1 change: 0 additions & 1 deletion Sources/Remote Logging/Crash Logging/CrashLogging.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ public class CrashLogging {
options.diagnosticLevel = .error

options.environment = self.dataProvider.buildType
options.releaseName = self.dataProvider.releaseName
options.enableAutoSessionTracking = self.dataProvider.shouldEnableAutomaticSessionTracking
options.enableAppHangTracking = self.dataProvider.enableAppHangTracking
options.enableCaptureFailedRequests = self.dataProvider.enableCaptureFailedRequests
Expand Down
5 changes: 0 additions & 5 deletions Sources/Remote Logging/Crash Logging/CrashLoggingDataProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public protocol CrashLoggingDataProvider {
var sentryDSN: String { get }
var userHasOptedOut: Bool { get }
var buildType: String { get }
var releaseName: String { get }
var currentUser: TracksUser? { get }
var additionalUserData: [String: Any] { get }
var shouldEnableAutomaticSessionTracking: Bool { get }
Expand All @@ -22,10 +21,6 @@ public protocol CrashLoggingDataProvider {
/// Default implementations of common protocol properties
public extension CrashLoggingDataProvider {

var releaseName: String {
return Bundle.main.object(forInfoDictionaryKey: kCFBundleVersionKey as String) as! String
}

var additionalUserData: [String: Any] {
return [ : ]
}
Expand Down