Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routine tooling upgrade #210

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Routine tooling upgrade #210

merged 7 commits into from
Aug 24, 2022

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Aug 24, 2022

I'll soon start working on upgrading the Sentry library integration. Before that, I thought I'd get the tooling in as up-to-date a state as I could.

@mokagio mokagio self-assigned this Aug 24, 2022
@mokagio mokagio requested a review from a team August 24, 2022 00:54
Something changed somewhere such that passing `'ios test'` to the
command would result in Fastlane looking for a lane called `ios test`
_without_ recognizing `ios` as the platform and `test` as the lane
within the platform.

Removing the single quotes seems to solve the issue.
@mokagio mokagio enabled auto-merge August 24, 2022 01:15
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@@ -21,7 +21,7 @@ steps:
# that occurs the first time after cleaning if one of your dependences uses a binary framework
# See https://bugs.swift.org/browse/SR-13803

build_and_test_pod 'ios test' || build_and_test_pod 'ios test'
build_and_test_pod ios test || build_and_test_pod ios test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch remembering to update those while updating from bash-cache 1.x to 2.x 👏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But really... CI failed, I didn't remember 🙃 But I'll take it anyway 💪

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤫 (I won't tell, promise 🤐) 😜

2.7.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

fastimage (2.2.5)
fastlane (2.191.0)
fastimage (2.2.6)
fastlane (2.209.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mokagio mokagio merged commit 9309eb0 into trunk Aug 24, 2022
@mokagio mokagio deleted the mokagio/ci-infra-update branch August 24, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants