Update Swift tools version from 5.3 to 5.5 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that this introduces an error when running `swift test`:
```
$ swift test
Building for debugging...
/Users/gio/Developer/a8c/tracks-apple-pod/Sources/Model/ObjC/Common/Core Data/TracksContextManager.m:24:24: error: use of undeclared identifier 'SWIFTPM_MODULE_BUNDLE'
NSBundle *bundle = SWIFTPM_MODULE_BUNDLE;
^
1 error generated.
[0/6] Compiling TracksContextManager.m
error: fatalError
```
This is a known Swift Package Manager issue. See:
- swiftlang/swift-package-manager#4500
- https://forums.swift.org/t/5-3-resources-support-not-working-on-with-swift-test/40381
However, `bundle exec fastlane test`, which uses `xcodebuild` under the
hood, works.
Given our workflow is based on Xcode locally and Fastlane in CI, the
regression seems acceptable.
The reason I'm keen to upgrade to 5.5 is that it's the required tooling
version to integrate Buildkite's Test Analytics. See
https://github.com/buildkite/test-collector-swift/blob/v0.1.0/Package.swift#L1
mokagio
force-pushed
the
use-swift-5.5-tooling
branch
from
51a730a to
a1eedab
Compare
5.5 Swift tools were introduced in the previous commit, bc86865
mokagio
force-pushed
the
use-swift-5.5-tooling
branch
from
a1eedab to
acd4b88
Compare
AliSoftware
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that this introduces an error when running
swift test:This is a known Swift Package Manager issue. See:
However,
bundle exec fastlane test, which usesxcodebuildunder the hood, works.Given our workflow is based on Xcode locally and Fastlane in CI, the regression seems acceptable.
The reason I'm keen to upgrade to 5.5 is that it's the required tooling version to integrate Buildkite's Test Analytics. See
https://github.com/buildkite/test-collector-swift/blob/v0.1.0/Package.swift#L1